diff options
| author | Peter Lemenkov <lemenkov@gmail.com> | 2019-12-26 21:17:33 +0300 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-12-31 15:21:19 +0000 |
| commit | d225834220cfbe59850a97092674c4d55faff757 (patch) | |
| tree | e99a2674b526f5e5ec09061a1829e605e9d3a36d /src/mainboard/gigabyte | |
| parent | 2450a7e72475fb98c3fa9d643cbc00f74f688fde (diff) | |
| download | coreboot-d225834220cfbe59850a97092674c4d55faff757.tar.xz | |
mb/*/*/acpi_tables: Don't initialize already initialized fields
Don't initialize fields with zeroes since gnvs structs were zeroed out
in southbridge already. See
* src/southbridge/intel/*/lpc.c
Change-Id: I5228f2cdc94df722ffa687c45b4e4fd25e82df82
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37967
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/gigabyte')
| -rw-r--r-- | src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c | 8 | ||||
| -rw-r--r-- | src/mainboard/gigabyte/ga-h61m-s2pv/acpi_tables.c | 7 |
2 files changed, 0 insertions, 15 deletions
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c index 59eb25a40f..441ebc254b 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c @@ -19,14 +19,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { - /* Disable USB ports in S3 by default */ - gnvs->s3u0 = 0; - gnvs->s3u1 = 0; - - /* Disable USB ports in S5 by default */ - gnvs->s5u0 = 0; - gnvs->s5u1 = 0; - gnvs->tcrt = CRITICAL_TEMPERATURE; gnvs->tpsv = PASSIVE_TEMPERATURE; } diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/acpi_tables.c b/src/mainboard/gigabyte/ga-h61m-s2pv/acpi_tables.c index 5eb07796c6..b5b4b4065f 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/acpi_tables.c +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/acpi_tables.c @@ -17,11 +17,4 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { - /* Disable USB ports in S3 by default */ - gnvs->s3u0 = 0; - gnvs->s3u1 = 0; - - /* Disable USB ports in S5 by default */ - gnvs->s5u0 = 0; - gnvs->s5u1 = 0; } |