summaryrefslogtreecommitdiff
path: root/src/mainboard/google/beltino
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2017-08-18 14:41:12 -0500
committerMartin Roth <martinroth@google.com>2017-08-25 19:23:46 +0000
commita2d9afc5eaa0ddc337d3993ef21720045872fc26 (patch)
treeb164d429ffeee8d66f05790e8cbc391a7cd4c410 /src/mainboard/google/beltino
parentf15e170de317cfa34af4f6d8beaf541f19628209 (diff)
downloadcoreboot-a2d9afc5eaa0ddc337d3993ef21720045872fc26.tar.xz
google/beltino: fix LED polarity for mccloud variant
The LED polarity was set incorrectly, fix using values derived from original Chromium sources: branch firmware-mccloud-5827.B, ToT src/mainboard/google/mccloud/smihandler.c src/mainboard/google/mccloud/romstage.c TEST: boot google/mccloud, observe power LED on normally, blinking in S3/S4, and off in S5. Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/21102 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/mainboard/google/beltino')
-rw-r--r--src/mainboard/google/beltino/variants/mccloud/led.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/beltino/variants/mccloud/led.c b/src/mainboard/google/beltino/variants/mccloud/led.c
index ce8d2d861c..b47e50a5a1 100644
--- a/src/mainboard/google/beltino/variants/mccloud/led.c
+++ b/src/mainboard/google/beltino/variants/mccloud/led.c
@@ -22,7 +22,7 @@ void set_power_led(int state)
it8772f_gpio_led(IT8772F_GPIO_DEV,
1, /* set */
0x01, /* select */
- state == LED_OFF ? 0x00 : 0x01, /* polarity */
+ state == LED_BLINK ? 0x01 : 0x00, /* polarity */
state == LED_BLINK ? 0x01 : 0x00, /* pullup/pulldown */
0x01, /* output */
state == LED_BLINK ? 0x00 : 0x01, /* I/O function */