diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2017-10-07 17:01:04 -0500 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-10-13 14:30:21 +0000 |
| commit | a34cf524692737b83bfdf7e482ddf15ab9108c0d (patch) | |
| tree | cb3347fdd767733449fbb486d3aa9142cb1f5678 /src/mainboard/google/cyan/variants/celes/spd_util.c | |
| parent | 8a02727f508826ef8f1e8bbe7581eedc2e0c1198 (diff) | |
| download | coreboot-a34cf524692737b83bfdf7e482ddf15ab9108c0d.tar.xz | |
google/cyan variants: fix single/dual channel reporting
Fix typos in determining single/dual channel in cyan variants
which resulted in all boards being reported as 4GB/dual channel
in the cbmem console log.
These typos were found and fixed in yet-to-be-merged variants;
this patch applies the same fixes to already-merged boards.
Change-Id: I615463668e77bd817d5270f0f04d4d01f74e3b47
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/21917
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/mainboard/google/cyan/variants/celes/spd_util.c')
| -rw-r--r-- | src/mainboard/google/cyan/variants/celes/spd_util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/cyan/variants/celes/spd_util.c b/src/mainboard/google/cyan/variants/celes/spd_util.c index d6253368e9..baf67053f6 100644 --- a/src/mainboard/google/cyan/variants/celes/spd_util.c +++ b/src/mainboard/google/cyan/variants/celes/spd_util.c @@ -49,10 +49,10 @@ int get_variant_spd_index(int ram_id, int *dual) /* Determine if single or dual channel memory system */ /* RAMID3 is deterministic for celes */ - *dual = ((ram_id > 3) & 0x1) ? 0 : 1; + *dual = ((ram_id >> 3) & 0x1) ? 0 : 1; /* Display the RAM type */ - printk(BIOS_DEBUG, dual ? "4GiB " : "2GiB "); + printk(BIOS_DEBUG, *dual ? "4GiB " : "2GiB "); switch (spd_index) { case 0: printk(BIOS_DEBUG, "Samsung K4E8E304EE-EGCE\n"); |