summaryrefslogtreecommitdiff
path: root/src/mainboard/google/dedede
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@google.com>2020-04-17 10:16:52 -0600
committerPatrick Georgi <pgeorgi@google.com>2020-04-20 06:25:50 +0000
commitda38715ec3cef00ffa893a2adbee30674bf5f9a4 (patch)
tree8fb26f5a187a876ce182dd3d03bef09873896dbb /src/mainboard/google/dedede
parent816c5cb9fc431a46368e7b8f3596d92653a831e0 (diff)
downloadcoreboot-da38715ec3cef00ffa893a2adbee30674bf5f9a4.tar.xz
mb/google/dedede: Read DRAM population strap
Configure DRAM population strap GPIO according to the schematics. Configure an internal pull-up to support the boards in which the strap is not populated. Read the strap and pass that information to FSP for memory initialization. BUG=b:152275658, b:154301008 TEST=Build and boot the mainboard. Ensure that the strap information is read as expected and passed to FSP. Change-Id: I69583f35ffc219bae9ce06bd4ba9898ed0d4d21d Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39812 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/dedede')
-rw-r--r--src/mainboard/google/dedede/romstage.c6
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/gpio.c5
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h3
3 files changed, 11 insertions, 3 deletions
diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c
index f95e7aacc3..2efaaf17e7 100644
--- a/src/mainboard/google/dedede/romstage.c
+++ b/src/mainboard/google/dedede/romstage.c
@@ -6,8 +6,10 @@
*/
#include <baseboard/variants.h>
+#include <gpio.h>
#include <soc/meminit.h>
#include <soc/romstage.h>
+#include <variant/gpio.h>
void mainboard_memory_init_params(FSPM_UPD *memupd)
{
@@ -16,7 +18,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
.read_type = READ_SPD_CBFS,
.spd_spec.spd_index = variant_memory_sku(),
};
- /* TODO: Read the resistor strap to get number of memory segments. */
- bool half_populated = 0;
+ bool half_populated = !gpio_get(GPIO_MEM_CH_SEL);
+
memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated);
}
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c
index d12d2c464d..a4ce97d8a5 100644
--- a/src/mainboard/google/dedede/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c
@@ -348,7 +348,7 @@ static const struct pad_config gpio_table[] = {
/* S0 : RAM_STRAP_4 */
- PAD_NC(GPP_S0, NONE),
+ PAD_CFG_GPI(GPP_S0, UP_5K, DEEP),
/* S1 : RSVD_STRAP */
PAD_NC(GPP_S1, NONE),
/* S2 : DMIC1_CLK */
@@ -416,6 +416,9 @@ static const struct pad_config early_gpio_table[] = {
/* H19 : BT_DISABLE_L */
PAD_CFG_GPO(GPP_H19, 0, DEEP),
+
+ /* S0 : RAM_STRAP_4 */
+ PAD_CFG_GPI(GPP_S0, UP_5K, DEEP),
};
const struct pad_config *__weak variant_gpio_table(size_t *num)
diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h
index dfb2cd1bd7..98e4b277f7 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h
@@ -26,4 +26,7 @@
#define GPIO_MEM_CONFIG_2 GPP_C4
#define GPIO_MEM_CONFIG_3 GPP_C5
+/* Memory channel select strap - 0: half-populated, 1: fully-populated */
+#define GPIO_MEM_CH_SEL GPP_S0
+
#endif /* __BASEBOARD_GPIO_H__ */