diff options
author | Shelley Chen <shchen@google.com> | 2019-02-06 13:55:09 -0800 |
---|---|---|
committer | Shelley Chen <shchen@google.com> | 2019-02-08 19:01:32 +0000 |
commit | 98ce3f8dadc3e84fbee4b141227c6acc79d4788f (patch) | |
tree | 0fde494638746c0178ab987b12513f6ed73e5ac7 /src/mainboard/google/hatch/variants/baseboard/Makefile.inc | |
parent | fa9c6f13d2734ddaad6197564e3a072a4cecd515 (diff) | |
download | coreboot-98ce3f8dadc3e84fbee4b141227c6acc79d4788f.tar.xz |
mb/google/hatch: Replace part-specific SPD files with generic ones
Traditionally, we have always allocated 1 DRAM ID per part number.
However, on nami, we have run out of DRAM IDs because we have
supported so many different parts. We are now adopting the use of
generic SPD files that are feature-based rather than specific to each
part, allowing us to support multiple parts with a single SPD.
The common SPDs were created by taking current SPDs in Nami (which is
using the same DDR4 parts as Hatch) and zeroing out all the
manufacturer information and part names. Additionally, we zeroed out
bytes 128 (raw card extension, module nominal height), 129 (module
maximum thickness), and 130 (reference raw card used) after verifying
that they are not used in FSP. We verified with these fields zeroed
out, all nami devices could boot up without errors. We also verified
on the two Hatch skus that we have (4G 2400, 8G 2666) that the generic
SPDs boot properly.
BUG=b:122959294
BRANCH=None
TEST=Make sure that we can boot up on both 4G Samsung and 8G Hynix DDR4
devices that we currently have.
Change-Id: I14d9e6b13975b6a65b506e6cd475160711b8f6d4
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://review.coreboot.org/c/31261
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/google/hatch/variants/baseboard/Makefile.inc')
-rw-r--r-- | src/mainboard/google/hatch/variants/baseboard/Makefile.inc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/mainboard/google/hatch/variants/baseboard/Makefile.inc b/src/mainboard/google/hatch/variants/baseboard/Makefile.inc index 182f283feb..074fc54861 100644 --- a/src/mainboard/google/hatch/variants/baseboard/Makefile.inc +++ b/src/mainboard/google/hatch/variants/baseboard/Makefile.inc @@ -1,6 +1,7 @@ ## This file is part of the coreboot project. ## ## Copyright (C) 2018 Intel Corporation. +## Copyright 2019 Google LLC ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -12,12 +13,12 @@ ## GNU General Public License for more details. ## -SPD_SOURCES = samsung_dimm_K4A4G165WE-BCRC-4GB # 0b000 +SPD_SOURCES = 4G_2400 # 0b000 SPD_SOURCES += empty_ddr4 # 0b001 SPD_SOURCES += empty_ddr4 # 0b010 SPD_SOURCES += empty_ddr4 # 0b011 SPD_SOURCES += empty_ddr4 # 0b100 -SPD_SOURCES += hynix_dimm_H5AN8G6NCJR-VKC-8GB # 0b101 +SPD_SOURCES += 8G_2666 # 0b101 bootblock-y += gpio.c |