summaryrefslogtreecommitdiff
path: root/src/mainboard/google/hatch
diff options
context:
space:
mode:
authorPhilip Chen <philipchen@google.com>2019-09-11 13:50:35 -0700
committerFurquan Shaikh <furquan@google.com>2019-09-13 03:12:31 +0000
commit48427512d6f8248f95aab5cff95f1c67f984258d (patch)
tree583076869ae69e614e29d086cad7cb64f4d5e502 /src/mainboard/google/hatch
parent09d50671e6b43c23853a91ff4d6fb26c1e7e17a1 (diff)
downloadcoreboot-48427512d6f8248f95aab5cff95f1c67f984258d.tar.xz
mb/google/hatch/var: Increase Goodix touchscreen reset delay to 500ms
Even though GT7375P programming guide rev0.4 only requires a reset delay of 120ms, in practice, we have to increase the reset delay to 500ms, or Goodix FW update would fail. This is a workaround. In the long run, we hope Goodix can fix the power sequence in touch firmware. BUG=b:138795891, b:138796844 TEST=boot helios board and verify Goodix FW update succeeded Signed-off-by: Philip Chen <philipchen@google.com> Change-Id: Ic0049bf240de0a1c7f1b1f39bf155d48bb76fb86 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35350 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/hatch')
-rw-r--r--src/mainboard/google/hatch/variants/hatch/overridetree.cb2
-rw-r--r--src/mainboard/google/hatch/variants/helios/overridetree.cb2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
index 6ed25c80ca..df2cc381e9 100644
--- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
@@ -98,7 +98,7 @@ chip soc/intel/cannonlake
register "generic.probed" = "1"
register "generic.reset_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)"
- register "generic.reset_delay_ms" = "120"
+ register "generic.reset_delay_ms" = "500"
register "generic.reset_off_delay_ms" = "3"
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
register "generic.enable_delay_ms" = "12"
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb
index b3da8c9181..8ca878d43c 100644
--- a/src/mainboard/google/hatch/variants/helios/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb
@@ -103,7 +103,7 @@ chip soc/intel/cannonlake
register "generic.probed" = "1"
register "generic.reset_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)"
- register "generic.reset_delay_ms" = "120"
+ register "generic.reset_delay_ms" = "500"
register "generic.reset_off_delay_ms" = "1"
register "generic.enable_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"