diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2015-04-01 08:49:41 -0500 |
|---|---|---|
| committer | Aaron Durbin <adurbin@google.com> | 2015-04-01 22:51:41 +0200 |
| commit | 3e91cffd894336c7ec802f0fc49e25e2a3b4efc6 (patch) | |
| tree | 26fe2c2b82c1c90d930efdb7290d858733cba9b8 /src/mainboard/google/link | |
| parent | a30f7e667ca56fdfeea98cbe736b61b67048c621 (diff) | |
| download | coreboot-3e91cffd894336c7ec802f0fc49e25e2a3b4efc6.tar.xz | |
mainboards: fix spd generation
echo is evaluated by a shell builtin producing non-binary
spd data of the form '-e -n \<byte>'. Correct this by
using printf builtin which does the equivalent and is
more cross platform friendly.
Boards changed:
gizmosphere/gizmo
gizmosphere/gizmo2
google/bolt
google/falco
google/link
google/peppy
google/rambi
google/samus
google/slippy
pcengines/apu1
Change-Id: Iefdaf59903b9682cc88c94fd991883b560616492
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/9196
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/mainboard/google/link')
| -rw-r--r-- | src/mainboard/google/link/Makefile.inc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/mainboard/google/link/Makefile.inc b/src/mainboard/google/link/Makefile.inc index 62746adbea..bd2cbf5842 100644 --- a/src/mainboard/google/link/Makefile.inc +++ b/src/mainboard/google/link/Makefile.inc @@ -37,7 +37,11 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd. # Include spd rom data $(SPD_BIN): $(SPD_DEPS) - for f in $^; do for c in $$(cat $$f); do echo -e -n "\\x$$c"; done; done > $@ + for f in $+; \ + do for c in $$(cat $$f | grep -v ^#); \ + do printf $$(printf '\%o' 0x$$c); \ + done; \ + done > $@ cbfs-files-y += spd.bin spd.bin-file := $(SPD_BIN) |