summaryrefslogtreecommitdiff
path: root/src/mainboard/google/octopus/variants/bobba
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2018-11-21 14:02:59 -0800
committerPatrick Georgi <pgeorgi@google.com>2018-11-27 08:49:08 +0000
commitae2cf495084325c6f4a0cb87b96167def77a80cc (patch)
tree722e97d45675194efcd5680d5ef036a8e52f9146 /src/mainboard/google/octopus/variants/bobba
parentc529f5b7f242bc221ff1d638330a1bb1678f6507 (diff)
downloadcoreboot-ae2cf495084325c6f4a0cb87b96167def77a80cc.tar.xz
mb/google/octopus: Update GPIO_178 in early_gpio_table in baseboard
This change updates the configuration of GPIO_178 to be active low as per latest revision on different octopus variants. This effectively: 1. Gets rid of early_gpio_table in different variants -- phaser, meep, fleex, bobba. 2. Deprecates board id < 2 for bobba, board id < 1 for fleex and phaser. 3. Adds special early_gpio_table in yorp which has GPIO_178 as an active high signal. BUG=b:119885949 Change-Id: I024199a8f1f96db57f8fa60c4d265789cd3a0493 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/29784 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org>
Diffstat (limited to 'src/mainboard/google/octopus/variants/bobba')
-rw-r--r--src/mainboard/google/octopus/variants/bobba/gpio.c45
1 files changed, 0 insertions, 45 deletions
diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c
index 6b471e5061..1b5c0bb069 100644
--- a/src/mainboard/google/octopus/variants/bobba/gpio.c
+++ b/src/mainboard/google/octopus/variants/bobba/gpio.c
@@ -49,48 +49,3 @@ const struct pad_config *variant_override_gpio_table(size_t *num)
}
return c;
}
-
-/* GPIOs needed prior to ramstage. */
-static const struct pad_config early_gpio_table[] = {
- /* PCH_WP_OD */
- PAD_CFG_GPI(GPIO_190, NONE, DEEP),
- /* H1_PCH_INT_ODL */
- PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE,
- DISPUPD),
- /* H1_SLAVE_SPI_CLK_R */
- PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1),
- /* H1_SLAVE_SPI_CS_L_R */
- PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1),
- /* H1_SLAVE_SPI_MISO */
- PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1),
- /* H1_SLAVE_SPI_MOSI_R */
- PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1),
-
- /* WLAN_PE_RST */
- PAD_CFG_GPO(GPIO_164, 0, DEEP),
-
- /*
- * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak
- * pull-up for proper operation. Since there is no external pull present
- * on this platform, configure an internal weak pull-up.
- */
- PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,
- ENPU),
-};
-
-const struct pad_config *variant_early_gpio_table(size_t *num)
-{
- /*
- * This is a hack to configure EN_PP3300_WLAN based on board id. Once
- * board id 0/1 is deprecated, we can get rid of this.
- */
- uint32_t bid = board_id();
-
- if (bid == UNDEFINED_STRAPPING_ID || bid < 2)
- gpio_output(GPIO_178, 1);
- else
- gpio_output(GPIO_178, 0);
-
- *num = ARRAY_SIZE(early_gpio_table);
- return early_gpio_table;
-}