summaryrefslogtreecommitdiff
path: root/src/mainboard/google/parrot
diff options
context:
space:
mode:
authorMatt Delco <delco@chromium.org>2019-04-30 14:59:43 -0700
committerPatrick Georgi <pgeorgi@google.com>2019-05-13 09:21:51 +0000
commit2cb399625ea04027fd02e6be834738b62d10c7d9 (patch)
treeadcefb02fd1e2cab4bf9ca52342dd91cb49d296b /src/mainboard/google/parrot
parenta20e59da157231f0a0e41774af80f6bccde1b280 (diff)
downloadcoreboot-2cb399625ea04027fd02e6be834738b62d10c7d9.tar.xz
mainboard: remove "recovery" gpio, selectively add "presence" gpio.
The gpio table is only used by depthcharge, and depthcharge rarely has a need for the "recovery" gpio. On a few boards it does use the gpio as a signal for confirming physical presence, so on that boards we'll advertise the board as "presence". All these strings probably should have been #defines to help avoid typos (e.g., the "ec_in_rw" in stout seems questionable since everybody else uses "EC in RW"). Cq-Depend: chromium:1580454 BUG=b:129471321 BRANCH=None TEST=Local compile and flash (with corresponding changes to depthcharge) to 2 systems, one with a "presence" gpio and another without. Confirmed that both systems could enter dev mode. Change-Id: Id6d62d9e48d3e6646cbc1277ea53f0ca95dd849e Signed-off-by: Matt Delco <delco@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32718 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/mainboard/google/parrot')
-rw-r--r--src/mainboard/google/parrot/chromeos.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c
index f17b6a64e1..095d5049ed 100644
--- a/src/mainboard/google/parrot/chromeos.c
+++ b/src/mainboard/google/parrot/chromeos.c
@@ -39,9 +39,6 @@ void fill_lb_gpios(struct lb_gpios *gpios)
/* Write Protect: GPIO70 active high */
{70, ACTIVE_LOW, !get_write_protect_state(), "write protect"},
- /* Recovery: Virtual GPIO in the EC (Servo GPIO68 active low) */
- {-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"},
-
/* Lid switch GPIO active high (open). */
{15, ACTIVE_HIGH, get_lid_switch(), "lid"},