summaryrefslogtreecommitdiff
path: root/src/mainboard/google/poppy/Kconfig
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2018-06-29 11:17:03 -0700
committerFurquan Shaikh <furquan@google.com>2018-07-03 04:04:52 +0000
commit54c2cc1b29a9b2e1a80f5b32d46914a4a801fe67 (patch)
tree67fb8cb46dbd5085b2c6f22199677c2dfa06a3fd /src/mainboard/google/poppy/Kconfig
parent3d76725c415c2cae751fab62fdc51f505896af38 (diff)
downloadcoreboot-54c2cc1b29a9b2e1a80f5b32d46914a4a801fe67.tar.xz
mb/google/*: Remove selection of DRIVERS_PS2_KEYBOARD
Until now, chromeec was doing keyboard initialization for the boards that have DRIVERS_PS2_KEYBOARD selected. However, coreboot does not leave the keyboard controller in a default reset state. This could result in payloads or OS failing to probe the controller as there could be stale data buffered in the controller during the handoff. Since the boards using chromeec already perform keyboard initialization in payload, there is no need to initialize the keyboard in coreboot too. This change gets rid of DRIVERS_PS2_KEYBOARD selection from all google mainboards using chromeec. BUG=b:110024487 TEST=Keyboard works fine after booting to OS even if user hits keys during BIOS to OS handoff. Change-Id: I1f49b060eb005c0f2b86f9d68d6758954eeb3cf0 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/27291 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/poppy/Kconfig')
-rw-r--r--src/mainboard/google/poppy/Kconfig3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index b94c73032d..7ad846e283 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -138,7 +138,6 @@ config VARIANT_SPECIFIC_OPTIONS_ATLAS
select CHROMEOS_WIFI_SAR if CHROMEOS
select DRIVERS_I2C_MAX98373
select DRIVERS_I2C_DA7219
- select DRIVERS_PS2_KEYBOARD
select DRIVERS_SPI_ACPI
select EXCLUDE_NATIVE_SD_INTERFACE
select MAINBOARD_HAS_SPI_TPM_CR50
@@ -155,7 +154,6 @@ config VARIANT_SPECIFIC_OPTIONS_NAMI
select CHROMEOS_WIFI_SAR if CHROMEOS
select DRIVERS_GENERIC_MAX98357A
select DRIVERS_I2C_DA7219
- select DRIVERS_PS2_KEYBOARD
select DRIVERS_SPI_ACPI
select EXCLUDE_NATIVE_SD_INTERFACE
select MAINBOARD_HAS_SPI_TPM_CR50
@@ -165,7 +163,6 @@ config VARIANT_SPECIFIC_OPTIONS_NAUTILUS
select CHROMEOS_WIFI_SAR if CHROMEOS
select DRIVERS_GENERIC_MAX98357A
select DRIVERS_I2C_DA7219
- select DRIVERS_PS2_KEYBOARD
select VARIANT_HAS_CAMERA_ACPI
select MAINBOARD_HAS_I2C_TPM_CR50