diff options
| author | Furquan Shaikh <furquan@chromium.org> | 2017-03-23 23:41:53 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-03-27 03:03:16 +0200 |
| commit | 5029a1668e0ca99ac64210967e22c971b0395efa (patch) | |
| tree | f67df6c276760e91bdb49a4aab393b6894f81408 /src/mainboard/google/slippy | |
| parent | 3795b03b69129367d57c93033785d7877aabc2cc (diff) | |
| download | coreboot-5029a1668e0ca99ac64210967e22c971b0395efa.tar.xz | |
ec: Use EC_ENABLE_LID_SWITCH for all mainboards with LID using chromeec
Instead of defining a separate LID device for mainboards using
chromeec, define EC_ENABLE_LID_SWITCH for these boards.
Change-Id: Iac58847c2055fa27c19d02b2dbda6813d6dec3ec
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/18964
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard/google/slippy')
| -rw-r--r-- | src/mainboard/google/slippy/acpi/ec.asl | 8 | ||||
| -rw-r--r-- | src/mainboard/google/slippy/acpi/mainboard.asl | 14 | ||||
| -rw-r--r-- | src/mainboard/google/slippy/acpi/platform.asl | 2 |
3 files changed, 9 insertions, 15 deletions
diff --git a/src/mainboard/google/slippy/acpi/ec.asl b/src/mainboard/google/slippy/acpi/ec.asl index 58b9a55cc4..d4f62c4c91 100644 --- a/src/mainboard/google/slippy/acpi/ec.asl +++ b/src/mainboard/google/slippy/acpi/ec.asl @@ -16,5 +16,13 @@ /* mainboard configuration */ #include "../ec.h" +/* Enable LID switch and provide wake pin for EC */ +#define EC_ENABLE_LID_SWITCH +/* + * There is no GPIO for LID, the EC pulses WAKE# pin instead. + * There is no GPE for WAKE#, so fake it with PCI_EXP_WAKE. + */ +#define EC_ENABLE_WAKE_PIN 0x69 + /* ACPI code for EC functions */ #include <ec/google/chromeec/acpi/ec.asl> diff --git a/src/mainboard/google/slippy/acpi/mainboard.asl b/src/mainboard/google/slippy/acpi/mainboard.asl index 35bc1b4ca5..7605e9e57c 100644 --- a/src/mainboard/google/slippy/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/acpi/mainboard.asl @@ -16,20 +16,6 @@ Scope (\_SB) { - Device (LID0) - { - Name(_HID, EisaId("PNP0C0D")) - Method(_LID, 0) - { - Store (\_SB.PCI0.LPCB.EC0.LIDS, \LIDS) - Return (\LIDS) - } - - // There is no GPIO for LID, the EC pulses WAKE# pin instead. - // There is no GPE for WAKE#, so fake it with PCI_EXP_WAKE - Name (_PRW, Package(){ 0x69, 5 }) // PCI_EXP - } - Device (PWRB) { Name(_HID, EisaId("PNP0C0C")) diff --git a/src/mainboard/google/slippy/acpi/platform.asl b/src/mainboard/google/slippy/acpi/platform.asl index 1bd054da06..7074336fa2 100644 --- a/src/mainboard/google/slippy/acpi/platform.asl +++ b/src/mainboard/google/slippy/acpi/platform.asl @@ -75,7 +75,7 @@ Method(_WAK,1) Store (\_SB.PCI0.LPCB.EC0.LIDS, Local0) if (LNotEqual (Local0, \LIDS)) { Store (Local0, \LIDS) - Notify (\_SB.LID0, 0x80) + Notify (\_SB.PCI0.LPCB.EC0.LID0, 0x80) } Return(Package(){0,0}) |