summaryrefslogtreecommitdiff
path: root/src/mainboard/google/volteer
diff options
context:
space:
mode:
authorShreesh Chhabbi <shreesh.chhabbi@intel.com>2020-06-17 12:40:42 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-07-14 16:07:25 +0000
commit370868766b90ce4bfa0342b6266a232b5326df50 (patch)
tree410a6d2d14072ec9a2c2a54e3ab5139a6f1b7f82 /src/mainboard/google/volteer
parent8cf43f6c98346fdfa58f978c68371c51f0f99e16 (diff)
downloadcoreboot-370868766b90ce4bfa0342b6266a232b5326df50.tar.xz
mainboard/volteer: Enable SaGv for volteer2, delbin & voxel
SaGv needs to be enabled for only QS. On ES2, we are seeing system instability. BUG=b:159198381 TEST=Tested for boot. Power and performance tests were run with volteer2 with qs setup. System showed stability. Tested for boot stability on on delbin. Change-Id: I1bce3b9f837fb19ba5a20ae31750a73474a86788 Signed-off-by: Shreesh Chhabbi <shreesh.chhabbi@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/42483 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Caveh Jalali <caveh@chromium.org>
Diffstat (limited to 'src/mainboard/google/volteer')
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/devicetree.cb2
-rw-r--r--src/mainboard/google/volteer/variants/delbin/overridetree.cb1
-rw-r--r--src/mainboard/google/volteer/variants/halvor/overridetree.cb2
-rw-r--r--src/mainboard/google/volteer/variants/malefor/overridetree.cb2
-rw-r--r--src/mainboard/google/volteer/variants/terrador/overridetree.cb2
-rw-r--r--src/mainboard/google/volteer/variants/trondo/overridetree.cb1
-rw-r--r--src/mainboard/google/volteer/variants/volteer/overridetree.cb1
7 files changed, 9 insertions, 2 deletions
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 322389dc07..18bfcc4ff7 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -47,7 +47,7 @@ chip soc/intel/tigerlake
register "HeciEnabled" = "1"
# FSP configuration
- register "SaGv" = "SaGv_Disabled"
+ register "SaGv" = "SaGv_Enabled"
register "SmbusEnable" = "0"
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
index 32204c58e7..9b5ae62bba 100644
--- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -1,5 +1,4 @@
chip soc/intel/tigerlake
-
device domain 0 on
end
diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb
index e53132a008..12e059c100 100644
--- a/src/mainboard/google/volteer/variants/halvor/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb
@@ -15,6 +15,8 @@ chip soc/intel/tigerlake
register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC2)" # Type-A / Type-C Port 2
register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
+ register "SaGv" = "SaGv_Disabled"
+
device domain 0 on
device pci 15.0 on
chip drivers/i2c/generic
diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb
index b2a658c16f..c84ed833c5 100644
--- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb
@@ -17,6 +17,8 @@ chip soc/intel/tigerlake
register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
+ register "SaGv" = "SaGv_Disabled"
+
# I2C Port Config
register "SerialIoI2cMode" = "{
[PchSerialIoIndexI2C0] = PchSerialIoPci,
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
index 871ec24fa0..c1c386a621 100644
--- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
@@ -17,6 +17,8 @@ chip soc/intel/tigerlake
register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used
+ register "SaGv" = "SaGv_Disabled"
+
device domain 0 on
device pci 15.0 on
chip drivers/i2c/generic
diff --git a/src/mainboard/google/volteer/variants/trondo/overridetree.cb b/src/mainboard/google/volteer/variants/trondo/overridetree.cb
index 4bff10d40d..0932b6484c 100644
--- a/src/mainboard/google/volteer/variants/trondo/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/trondo/overridetree.cb
@@ -1,4 +1,5 @@
chip soc/intel/tigerlake
+ register "SaGv" = "SaGv_Disabled"
device domain 0 on
device pci 15.1 on
chip drivers/i2c/hid
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index 404b25764a..094476525f 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -1,4 +1,5 @@
chip soc/intel/tigerlake
+ register "SaGv" = "SaGv_Disabled"
device domain 0 on
device pci 15.0 on
chip drivers/i2c/generic