summaryrefslogtreecommitdiff
path: root/src/mainboard/google/zork
diff options
context:
space:
mode:
authorJosie Nordrum <JosieNordrum@google.com>2020-08-19 15:52:42 -0700
committerFurquan Shaikh <furquan@google.com>2020-08-21 22:05:11 +0000
commit4cc87d4e35899519be8bf28ffecf89f01eacc55c (patch)
tree22a1ce6ab2105b089f63caab937d9b8bd99d3a9f /src/mainboard/google/zork
parent6c5f47b50ce8a65ccf3039e109af3740572c5345 (diff)
downloadcoreboot-4cc87d4e35899519be8bf28ffecf89f01eacc55c.tar.xz
mb/google/zork/var/ezkinil: Fix stylus GPIO to enable suspend
Make GPIO_4 and GPIO_5 PAD_NC in ezkinil/gpio.c. None of the Ezkinil SKUs use internal stylus and hence pen pads are configured as NC. BUG=b:164892883, b:165342107 TEST=Verified taht pen detect GPIO does not cause spurious wakes. BRANCH=None Signed-off-by: Josie Nordrum <josienordrum@google.com> Change-Id: I7557575cf8b8e0f849e05bda1d69acf61e91a157 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44629 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/zork')
-rw-r--r--src/mainboard/google/zork/variants/ezkinil/gpio.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c
index f8664bb6cb..108a134dc6 100644
--- a/src/mainboard/google/zork/variants/ezkinil/gpio.c
+++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c
@@ -8,6 +8,10 @@
#include <ec/google/chromeec/ec.h>
static const struct soc_amd_gpio ezkinil_bid1_gpio_set_stage_ram[] = {
+ /* PEN_DETECT_ODL - Not connected */
+ PAD_NC(GPIO_4),
+ /* PEN_POWER_EN - Not connected */
+ PAD_NC(GPIO_5),
/* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */
@@ -29,6 +33,10 @@ static const struct soc_amd_gpio ezkinil_bid1_gpio_set_stage_ram[] = {
};
static const struct soc_amd_gpio ezkinil_bid2_gpio_set_stage_ram[] = {
+ /* PEN_DETECT_ODL - Not connected */
+ PAD_NC(GPIO_4),
+ /* PEN_POWER_EN - Not connected */
+ PAD_NC(GPIO_5),
/* FPMCU_RST_L Change NC */
PAD_NC(GPIO_11),
/* DMIC_SEL */
@@ -50,6 +58,10 @@ static const struct soc_amd_gpio ezkinil_bid2_gpio_set_stage_ram[] = {
};
static const struct soc_amd_gpio ezkinil_bid3_gpio_set_stage_ram[] = {
+ /* PEN_DETECT_ODL - Not connected */
+ PAD_NC(GPIO_4),
+ /* PEN_POWER_EN - Not connected */
+ PAD_NC(GPIO_5),
/* FPMCU_RST_L Change NC */
PAD_NC(GPIO_11),
/* FPMCU_BOOT0 Change NC */