summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2020-07-14 18:29:19 -0700
committerJulius Werner <jwerner@chromium.org>2020-07-16 00:58:24 +0000
commitaa4c1d2b5b3dd210e09239fb28e5cd0a8bd6b0fc (patch)
tree39dac797e8f4956dd347d521192788c3e56044e8 /src/mainboard/google
parent9754f38e8242580bc338aa510bbebd63e544f7b1 (diff)
downloadcoreboot-aa4c1d2b5b3dd210e09239fb28e5cd0a8bd6b0fc.tar.xz
google/trogdor: Remove GPIO_AP_SUSPEND_L
This pin has been removed from recent revisions (or at least moved to a pin that's not controlled like a normal GPIO). It has also never been used on older ones (I think?). The same GPIO is now used as a SKU ID pin, so make sure we're not incorrectly configuring it as an output (although sku_id() overrides that later anyway, but it's still incorrect). BUG=b:160754995 Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I6e0d56e230d0bef172d7b78cc48263e9b6f059de Reviewed-on: https://review.coreboot.org/c/coreboot/+/43471 Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Philip Chen <philipchen@google.com> Reviewed-by: Bob Moragues <moragues@google.com> Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/trogdor/board.h1
-rw-r--r--src/mainboard/google/trogdor/chromeos.c1
2 files changed, 0 insertions, 2 deletions
diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index 63d03db51c..cab44032eb 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -9,7 +9,6 @@
#define GPIO_EC_IN_RW GPIO(118)
#define GPIO_AP_EC_INT GPIO(94)
-#define GPIO_AP_SUSPEND GPIO(20)
#define GPIO_WP_STATE GPIO(42)
#define GPIO_H1_AP_INT (CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42))
#define GPIO_SD_CD_L GPIO(69)
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c
index 9360928a1e..9c45dfe71e 100644
--- a/src/mainboard/google/trogdor/chromeos.c
+++ b/src/mainboard/google/trogdor/chromeos.c
@@ -14,7 +14,6 @@ void setup_chromeos_gpios(void)
{
gpio_input_pullup(GPIO_EC_IN_RW);
gpio_input_pullup(GPIO_AP_EC_INT);
- gpio_output(GPIO_AP_SUSPEND, 1);
gpio_input(GPIO_WP_STATE);
gpio_input_pullup(GPIO_SD_CD_L);
gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);