summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorRicardo Ribalda <ribalda@chromium.org>2021-01-28 13:17:47 +0000
committerPatrick Georgi <pgeorgi@google.com>2021-02-01 08:48:16 +0000
commitfa21c922c6d963e93db5aeeec77229c4772f33be (patch)
tree2836a8faddeb28451d9dc9305c079df636a3627d /src/mainboard/google
parent3acea5c51abd09bb578cfb35952b9dbd96be21fe (diff)
downloadcoreboot-fa21c922c6d963e93db5aeeec77229c4772f33be.tar.xz
Revert "mb/google/hatch/dratini: Describe the privacy_gpio"
This reverts commit f41645c34d8b22a3d887abd56138ae794fc2dfa5. In Dragonair, during the MP stage, one of the resistors needed for this functionality has been removed. This results in the privacy-switch not readable back by the system. BUG=b:178458332 Change-Id: I0781f338d5ecd89fccee613fb13ea25c59385625 Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50044 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/hatch/variants/dratini/gpio.c2
-rw-r--r--src/mainboard/google/hatch/variants/dratini/overridetree.cb13
2 files changed, 0 insertions, 15 deletions
diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c
index 32591b82bf..712a9185d0 100644
--- a/src/mainboard/google/hatch/variants/dratini/gpio.c
+++ b/src/mainboard/google/hatch/variants/dratini/gpio.c
@@ -16,8 +16,6 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_A19, NONE),
/* C12 : FPMCU_PCH_BOOT1 */
PAD_CFG_GPO(GPP_C12, 0, DEEP),
- /* D4 : Camera Privacy Status */
- PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH),
/* F1 : NC */
PAD_NC(GPP_F1, NONE),
/* F3 : MEM_STRAP_3 */
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
index 3605196c11..6176fc6252 100644
--- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
@@ -72,19 +72,6 @@ chip soc/intel/cannonlake
device pci 02.0 on # Integrated Graphics Device
register "gfx" = "GMA_DEFAULT_PANEL(0)"
end
- device pci 14.0 on
- chip drivers/usb/acpi
- device usb 0.0 on
- chip drivers/usb/acpi
- # The Linux Kernel does not allow an inverted BOTH_EDGE irq
- # So we need to use GpioIO() instead of GpioInt()
- # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt
- register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)"
- device usb 2.6 on end
- end
- end
- end
- end # USB xHCI
device pci 15.0 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""