summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2015-06-10 22:31:28 -0500
committerStefan Reinauer <stefan.reinauer@coreboot.org>2015-06-12 04:19:57 +0200
commitebff038e8410271224c0b50e7092e0786b9056a5 (patch)
tree21fbe181ec720838a16d7c8be6204a2157308d72 /src/mainboard/google
parentdee4420318be0e4685d6e9a4a208eceef7e0b21c (diff)
downloadcoreboot-ebff038e8410271224c0b50e7092e0786b9056a5.tar.xz
google/panther: fix MAC address programming when VPD not present
Commit 899d13d (cbfs: new API and better program loading) broke panther's lan init when no vpd.bin present from which to read the MAC address. Fix this by checking the validity of the search address pointer, rather than the search length. Change-Id: I8c7ca410d8ce5c5d92242a21c4c2ff4c001a68bd Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: http://review.coreboot.org/10509 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/panther/lan.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/panther/lan.c b/src/mainboard/google/panther/lan.c
index 4b34c0678c..5d806dbb05 100644
--- a/src/mainboard/google/panther/lan.c
+++ b/src/mainboard/google/panther/lan.c
@@ -132,7 +132,7 @@ static void program_mac_address(u16 io_base)
&search_length);
}
- if (search_length <= 0)
+ if (search_address == NULL)
printk(BIOS_ERR, "LAN: VPD not found.\n");
else
get_mac_address(&high_dword, &low_dword, search_address,