diff options
| author | Sakari Ailus <sakari.ailus@linux.intel.com> | 2019-11-01 12:10:40 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-12-02 12:57:49 +0000 |
| commit | 2d54fc9581ef01fe03ef114cd6718f7b352c01fc (patch) | |
| tree | c291c8c6db76299511e2960e90ba9f26c50e3dd4 /src/mainboard/google | |
| parent | 1804b158969ab849ea7c6e47b1bb6b297c1f8e45 (diff) | |
| download | coreboot-2d54fc9581ef01fe03ef114cd6718f7b352c01fc.tar.xz | |
mb/google/poppy: Declare output GPIOs as pull-downs
The pull direction is used to determine the initial state of the pin. If
no pull direction is specified, the pin will remain as input. Fix this.
BUG=chromium:959232
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Jacopo Mondi <jacopo@jmondi.org>
Change-Id: I1158bc8aaa447b223e8ce25d808348e758de28c5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36721
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 5eaf5b758a..d3fafe9510 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -142,21 +142,21 @@ Scope (\_SB.PCI0.I2C2) 2 } /* GPIO.4 is AVDD pin for user facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { 4 } /* GPIO.5 is XSHUTDOWN pin for user facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { 5 } /* GPIO.9 is XSHUTDOWN pin for world facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { @@ -188,7 +188,7 @@ Scope (\_SB.PCI0.I2C2) GPO2, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) @@ -199,7 +199,7 @@ Scope (\_SB.PCI0.I2C2) GRST, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) @@ -210,7 +210,7 @@ Scope (\_SB.PCI0.I2C2) GPO4, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) |