diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2015-08-20 12:51:48 -0400 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2015-08-20 18:51:40 +0000 |
| commit | 43213be11657669a3bd93eb81320558ef1183faf (patch) | |
| tree | c0e0ba4f99dc562fa53c81ebea841cf74230509d /src/mainboard/google | |
| parent | af473ede1f8ff5fc63609b914570aad21827b2e7 (diff) | |
| download | coreboot-43213be11657669a3bd93eb81320558ef1183faf.tar.xz | |
mainboard: Get CHROMEOS/MAINBOARD_HAS_CHROMEOS right (again)
CHROMEOS is a user-visible bool. It must not be 'select'ed in Kconfig.
That's why we have MAINBOARD_HAS_CHROMEOS. This is the fifth time I
find this being used wrong.
Why is this confusing/so hard to get right?
Change-Id: Icb4629355c63508f5a044b46842524b3d203c2da
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/11290
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/cyan/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/google/glados/Kconfig | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 91f7587f8c..094c629881 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS select VGA_ROM_RUN if !PAYLOAD_SEABIOS select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS select BOARD_ROMSIZE_KB_8192 - select CHROMEOS select CHROMEOS_VBNV_CMOS select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_MEC diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index c7df2a388b..d91aca5618 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select BOARD_ROMSIZE_KB_16384 select CACHE_ROM - select CHROMEOS select CHROMEOS_RAMOOPS_DYNAMIC select CHROMEOS_VBNV_CMOS select EC_GOOGLE_CHROMEEC |