diff options
author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-03-28 14:48:13 -0500 |
---|---|---|
committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-03 20:19:22 +0200 |
commit | 1d87dac4e478608a2605b3e983128d32df8526f3 (patch) | |
tree | 4bc30a5269bdf0fbf93b214aef402d08171098e4 /src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c | |
parent | cb3ba5fdbc5cc9bd02b4aacf569cb455c34b81bc (diff) | |
download | coreboot-1d87dac4e478608a2605b3e983128d32df8526f3.tar.xz |
hp/pavilion_m6_1035dx: Sanitize #includes
There were a number of things wrong with the includes. First, The
includes did not use paths to AGESA files, thus relying on the
compiler include paths to find the correct file. This made it unclear
where the file included was located, and whether it was local, under
vendorcode, or under a different directory. Instead, use full paths
for each non-local include.
Second, the local includes were mixed with the rest, making it unclear
which file is local and which one is not. Keep the local includes at
the top. This also prevents us from polluting the namespace of local
headers, with library definitions, and allows us to catch if we missed
an otherwise needed external header.
Thirdly, alphabetize the order of includes where possible.
Change-Id: I22c543291beabb83c16d912ea0a490be6ca4e03c
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/5412
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c')
-rw-r--r-- | src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c b/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c index bf76fe2fe7..79a5380f20 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/get_bus_conf.c @@ -17,17 +17,16 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include "agesawrapper.h" + #include <console/console.h> +#include <cpu/amd/amdfam15.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <string.h> #include <stdint.h> #include <stdlib.h> -#include <cpu/amd/amdfam14.h> -#include "agesawrapper.h" -#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) -#include "imc.h" -#endif +#include <string.h> +#include <southbridge/amd/agesa/hudson/imc.h> /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. |