diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2012-11-15 15:15:15 -0800 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2012-11-16 05:07:28 +0100 |
| commit | a47bd91ccaf14626cab51a74b998d93f3d8af18c (patch) | |
| tree | df00189f77d9c48dcb6ed918093c11a7a69b4f29 /src/mainboard/hp | |
| parent | 56cd70bba2906cb99b84d593d90f7653b0ce1e0b (diff) | |
| download | coreboot-a47bd91ccaf14626cab51a74b998d93f3d8af18c.tar.xz | |
Fix PIRQ routing abstraction
intel_irq_routing_table is a local structure that should not be used
globally, because it might not be there on all mainboards.
Instead, the API has to be corrected to allow passing a PIRQ table in
where needed.
Change-Id: Icf08928b67727a366639b648bf6aac8e1a87e765
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/1862
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/mainboard/hp')
| -rw-r--r-- | src/mainboard/hp/dl145_g3/irq_tables.c | 4 | ||||
| -rw-r--r-- | src/mainboard/hp/dl165_g6_fam10/irq_tables.c | 4 | ||||
| -rw-r--r-- | src/mainboard/hp/e_vectra_p2706t/irq_tables.c | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/hp/dl145_g3/irq_tables.c b/src/mainboard/hp/dl145_g3/irq_tables.c index cdd5bd308d..2d2394b9d0 100644 --- a/src/mainboard/hp/dl145_g3/irq_tables.c +++ b/src/mainboard/hp/dl145_g3/irq_tables.c @@ -13,7 +13,7 @@ #include <arch/pirq_routing.h> #endif -const struct irq_routing_table intel_irq_routing_table = { +static const struct irq_routing_table intel_irq_routing_table = { PIRQ_SIGNATURE, /* u32 signature */ PIRQ_VERSION, /* u16 version */ 32+16*CONFIG_IRQ_SLOT_COUNT, /* There can be total CONFIG_IRQ_SLOT_COUNT devices on the bus */ @@ -54,6 +54,6 @@ const struct irq_routing_table intel_irq_routing_table = { unsigned long write_pirq_routing_table(unsigned long addr) { - return copy_pirq_routing_table(addr); + return copy_pirq_routing_table(addr, &intel_irq_routing_table); } diff --git a/src/mainboard/hp/dl165_g6_fam10/irq_tables.c b/src/mainboard/hp/dl165_g6_fam10/irq_tables.c index eb629e045a..1784aec88c 100644 --- a/src/mainboard/hp/dl165_g6_fam10/irq_tables.c +++ b/src/mainboard/hp/dl165_g6_fam10/irq_tables.c @@ -13,7 +13,7 @@ #include <arch/pirq_routing.h> #endif -const struct irq_routing_table intel_irq_routing_table = { +static const struct irq_routing_table intel_irq_routing_table = { PIRQ_SIGNATURE, /* u32 signature */ PIRQ_VERSION, /* u16 version */ 32 + 16 * 11, /* Max. number of devices on the bus */ @@ -47,5 +47,5 @@ const struct irq_routing_table intel_irq_routing_table = { unsigned long write_pirq_routing_table(unsigned long addr) { - return copy_pirq_routing_table(addr); + return copy_pirq_routing_table(addr, &intel_irq_routing_table); } diff --git a/src/mainboard/hp/e_vectra_p2706t/irq_tables.c b/src/mainboard/hp/e_vectra_p2706t/irq_tables.c index fe6f093660..1d27628e33 100644 --- a/src/mainboard/hp/e_vectra_p2706t/irq_tables.c +++ b/src/mainboard/hp/e_vectra_p2706t/irq_tables.c @@ -20,7 +20,7 @@ #include <arch/pirq_routing.h> -const struct irq_routing_table intel_irq_routing_table = { +static const struct irq_routing_table intel_irq_routing_table = { PIRQ_SIGNATURE, PIRQ_VERSION, 32 + 16 * CONFIG_IRQ_SLOT_COUNT,/* Max. number of devices on the bus */ @@ -42,5 +42,5 @@ const struct irq_routing_table intel_irq_routing_table = { unsigned long write_pirq_routing_table(unsigned long addr) { - return copy_pirq_routing_table(addr); + return copy_pirq_routing_table(addr, &intel_irq_routing_table); } |