mb/*/*/acpi_tables: Don't initialize already initialized fields

Don't initialize fields with zeroes since gnvs structs were zeroed out
in southbridge already. See

* src/southbridge/intel/*/lpc.c

Change-Id: I5228f2cdc94df722ffa687c45b4e4fd25e82df82
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37967
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

9 files changed, 0 insertions, 72 deletions

diff --git a/src/mainboard/hp/2570p/acpi_tables.c b/src/mainboard/hp/2570p/acpi_tables.c
index 7d634a04ef..114f6e1228 100644
--- a/src/mainboard/hp/2570p/acpi_tables.c
+++ b/src/mainboard/hp/2570p/acpi_tables.c
@@ -19,14 +19,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/2760p/acpi_tables.c b/src/mainboard/hp/2760p/acpi_tables.c
index d8d89e40bd..b278512b46 100644
--- a/src/mainboard/hp/2760p/acpi_tables.c
+++ b/src/mainboard/hp/2760p/acpi_tables.c
@@ -17,14 +17,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/8460p/acpi_tables.c b/src/mainboard/hp/8460p/acpi_tables.c
index 7d634a04ef..114f6e1228 100644
--- a/src/mainboard/hp/8460p/acpi_tables.c
+++ b/src/mainboard/hp/8460p/acpi_tables.c
@@ -19,14 +19,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/8470p/acpi_tables.c b/src/mainboard/hp/8470p/acpi_tables.c
index d8d89e40bd..b278512b46 100644
--- a/src/mainboard/hp/8470p/acpi_tables.c
+++ b/src/mainboard/hp/8470p/acpi_tables.c
@@ -17,14 +17,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/8770w/acpi_tables.c b/src/mainboard/hp/8770w/acpi_tables.c
index d8d89e40bd..b278512b46 100644
--- a/src/mainboard/hp/8770w/acpi_tables.c
+++ b/src/mainboard/hp/8770w/acpi_tables.c
@@ -17,14 +17,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c b/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c
index 084e7e5a5f..8866557eee 100644
--- a/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c
+++ b/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c
@@ -20,14 +20,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	gnvs->tcrt = 100;
 	gnvs->tpsv = 90;
 }
diff --git a/src/mainboard/hp/folio_9470m/acpi_tables.c b/src/mainboard/hp/folio_9470m/acpi_tables.c
index 7d634a04ef..114f6e1228 100644
--- a/src/mainboard/hp/folio_9470m/acpi_tables.c
+++ b/src/mainboard/hp/folio_9470m/acpi_tables.c
@@ -19,14 +19,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/revolve_810_g1/acpi_tables.c b/src/mainboard/hp/revolve_810_g1/acpi_tables.c
index 6b731ccfc7..4ef3b53792 100644
--- a/src/mainboard/hp/revolve_810_g1/acpi_tables.c
+++ b/src/mainboard/hp/revolve_810_g1/acpi_tables.c
@@ -20,14 +20,6 @@
 /* FIXME: check this function.  */
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	// the lid is open by default.
 	gnvs->lids = 1;
 
diff --git a/src/mainboard/hp/z220_sff_workstation/acpi_tables.c b/src/mainboard/hp/z220_sff_workstation/acpi_tables.c
index 084e7e5a5f..8866557eee 100644
--- a/src/mainboard/hp/z220_sff_workstation/acpi_tables.c
+++ b/src/mainboard/hp/z220_sff_workstation/acpi_tables.c
@@ -20,14 +20,6 @@
 
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
-	/* Disable USB ports in S3 by default */
-	gnvs->s3u0 = 0;
-	gnvs->s3u1 = 0;
-
-	/* Disable USB ports in S5 by default */
-	gnvs->s5u0 = 0;
-	gnvs->s5u1 = 0;
-
 	gnvs->tcrt = 100;
 	gnvs->tpsv = 90;
 }