diff options
author | Arthur Heymans <arthur@aheymans.xyz> | 2019-11-12 16:42:33 +0100 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-11-18 11:46:26 +0000 |
commit | 9c538348d8ccaef2c3dd6b898a1f44b00ea59690 (patch) | |
tree | 79eac3af79546b14b110b059e31eb18d33de4ce0 /src/mainboard/hp | |
parent | 934b8da442a04978c6320299c616d3e8f05cb731 (diff) | |
download | coreboot-9c538348d8ccaef2c3dd6b898a1f44b00ea59690.tar.xz |
nb/intel/sandybridge: Make the mainboard_rcba_config hook optional
This also changes the name to mainboard_late_rcba_config to better
reflect what it does.
This adds an empty weakly linked default. The rationale behind this
change is that without an implementation of the hook some features
might not work but that the result is likely still able to boot, so it
can be made optional.
Change-Id: I1897d0f5ca7427d304a425f5256cd43c088ff936
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36781
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/hp')
-rw-r--r-- | src/mainboard/hp/2570p/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/2760p/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/8460p/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/8470p/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/8770w/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/compaq_8200_elite_sff/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/folio_9470m/romstage.c | 4 | ||||
-rw-r--r-- | src/mainboard/hp/revolve_810_g1/romstage.c | 2 | ||||
-rw-r--r-- | src/mainboard/hp/z220_sff_workstation/romstage.c | 4 |
9 files changed, 1 insertions, 33 deletions
diff --git a/src/mainboard/hp/2570p/romstage.c b/src/mainboard/hp/2570p/romstage.c index 4f7ca3a18c..8d36f6b27d 100644 --- a/src/mainboard/hp/2570p/romstage.c +++ b/src/mainboard/hp/2570p/romstage.c @@ -24,10 +24,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 0, 1, 0 }, diff --git a/src/mainboard/hp/2760p/romstage.c b/src/mainboard/hp/2760p/romstage.c index a696faec36..5bf8789618 100644 --- a/src/mainboard/hp/2760p/romstage.c +++ b/src/mainboard/hp/2760p/romstage.c @@ -23,10 +23,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 1, 0 }, diff --git a/src/mainboard/hp/8460p/romstage.c b/src/mainboard/hp/8460p/romstage.c index 77c355bb23..397810eba7 100644 --- a/src/mainboard/hp/8460p/romstage.c +++ b/src/mainboard/hp/8460p/romstage.c @@ -27,10 +27,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, /* USB0, eSATA */ { 1, 0, 0 }, /* USB charger */ diff --git a/src/mainboard/hp/8470p/romstage.c b/src/mainboard/hp/8470p/romstage.c index 890e65b07c..513b3756e8 100644 --- a/src/mainboard/hp/8470p/romstage.c +++ b/src/mainboard/hp/8470p/romstage.c @@ -26,10 +26,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 1, 0 }, diff --git a/src/mainboard/hp/8770w/romstage.c b/src/mainboard/hp/8770w/romstage.c index 49a5b1af48..d3034fb565 100644 --- a/src/mainboard/hp/8770w/romstage.c +++ b/src/mainboard/hp/8770w/romstage.c @@ -27,10 +27,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, /* Dock USB3.0 */ { 1, 1, 0 }, /* Conn */ diff --git a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c index 90cfcc93aa..3e726cfb80 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c +++ b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c @@ -31,10 +31,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, -1 }, { 1, 0, -1 }, diff --git a/src/mainboard/hp/folio_9470m/romstage.c b/src/mainboard/hp/folio_9470m/romstage.c index 3f174a19fb..969b666d8f 100644 --- a/src/mainboard/hp/folio_9470m/romstage.c +++ b/src/mainboard/hp/folio_9470m/romstage.c @@ -25,10 +25,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, /* SSP1: dock */ { 1, 1, 0 }, /* SSP2: left, EHCI Debug */ diff --git a/src/mainboard/hp/revolve_810_g1/romstage.c b/src/mainboard/hp/revolve_810_g1/romstage.c index 8a40578f0a..844bb2f4e3 100644 --- a/src/mainboard/hp/revolve_810_g1/romstage.c +++ b/src/mainboard/hp/revolve_810_g1/romstage.c @@ -28,7 +28,7 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) +void mainboard_late_rcba_config(void) { RCBA32(BUC) = 0x00000000; } diff --git a/src/mainboard/hp/z220_sff_workstation/romstage.c b/src/mainboard/hp/z220_sff_workstation/romstage.c index bd0a377580..2e0a50806c 100644 --- a/src/mainboard/hp/z220_sff_workstation/romstage.c +++ b/src/mainboard/hp/z220_sff_workstation/romstage.c @@ -31,10 +31,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, 0 }, { 1, 0, 0 }, |