diff options
| author | Martin Roth <martinroth@google.com> | 2015-12-08 15:24:41 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-12-10 16:32:56 +0100 |
| commit | 3e41ee9847f0acd4a57c0c4cb11156eace16fd05 (patch) | |
| tree | 7c6d01a02ce23e9d4d0940c10674e018714489bf /src/mainboard/hp | |
| parent | f77516cb6dcc4671938475926d2ee55952cd2eec (diff) | |
| download | coreboot-3e41ee9847f0acd4a57c0c4cb11156eace16fd05.tar.xz | |
ACPI: Fix IASL Warning about unused method for _S3 check
According to the ACPI Spec for CondRefOf, the result argument is
optional. In all of these locations, it was getting set but not
used, creating a warning in new versions of IASL. Since it's
an optional argument, just remove it.
dsdt.aml 640: If (CondRefOf (\_S3, Local0))
Warning 3144 - Method Local is set but never used ^ (Local0)
Change-Id: I758d198c33e585a6a4ad2c1c70f2370a01af5138
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12693
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/hp')
| -rw-r--r-- | src/mainboard/hp/dl145_g1/acpi/amd8111.asl | 8 | ||||
| -rw-r--r-- | src/mainboard/hp/dl145_g1/acpi/amd8131.asl | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/hp/dl145_g1/acpi/amd8111.asl b/src/mainboard/hp/dl145_g1/acpi/amd8111.asl index aa136ffbf2..77389f0062 100644 --- a/src/mainboard/hp/dl145_g1/acpi/amd8111.asl +++ b/src/mainboard/hp/dl145_g1/acpi/amd8111.asl @@ -87,7 +87,7 @@ Device (TP2P) { // result : // [0] Bit index into GPEx_EN in the GPE block described by FADT. // [1] The lowest power state from which the system can be awakened. - //If (CondRefOf (\_S3, Local0)) { + //If (CondRefOf (\_S3)) { // Return (Package (0x02) { 0x08, 0x03 }) //} Else { Return (Package (0x02) { 0x08, 0x01 }) @@ -96,7 +96,7 @@ Device (TP2P) { Device (ETHR) { Name (_ADR, 0x00010000) Method (_PRW, 0, NotSerialized) { // Power Resource for Wake - //If (CondRefOf (\_S3, Local0)) { + //If (CondRefOf (\_S3)) { // Return (Package (0x02) { 0x08, 0x03 }) //} Else { Return (Package (0x02) { 0x08, 0x01 }) @@ -109,7 +109,7 @@ Device (TP2P) { And (GNBL, 0x7FFF, GNBL) } Method (_PRW, 0, NotSerialized) { // Power Resource for Wake - //If (CondRefOf (\_S3, Local0)) { + //If (CondRefOf (\_S3)) { // Return (Package (0x02) { 0x0F, 0x03 }) //} Else { Return (Package (0x02) { 0x0F, 0x01 }) @@ -122,7 +122,7 @@ Device (TP2P) { And (GNBL, 0x7FFF, GNBL) } Method (_PRW, 0, NotSerialized) { // Power Resource for Wake - //If (CondRefOf (\_S3, Local0)) { + //If (CondRefOf (\_S3)) { // Return (Package (0x02) { 0x0F, 0x03 }) //} Else { Return (Package (0x02) { 0x0F, 0x01 }) diff --git a/src/mainboard/hp/dl145_g1/acpi/amd8131.asl b/src/mainboard/hp/dl145_g1/acpi/amd8131.asl index 54aae73aff..29808aabd9 100644 --- a/src/mainboard/hp/dl145_g1/acpi/amd8131.asl +++ b/src/mainboard/hp/dl145_g1/acpi/amd8131.asl @@ -9,7 +9,7 @@ Device (PG0A) { Return (DADD(GHCD(HCIN, 0), 0x00000000)) } Method (_PRW, 0, NotSerialized) { - //If (CondRefOf (\_S3, Local0)) { + //If (CondRefOf (\_S3)) { // Return (Package (0x02) { 0x29, 0x03 }) //} Else { Return (Package (0x02) { 0x29, 0x01 }) @@ -75,7 +75,7 @@ Device (PG0B) { Return (DADD(GHCD(HCIN, 0), 0x00010000)) } Method (_PRW, 0, NotSerialized) { - //If (CondRefOf (\_S3, Local0)) { + //If (CondRefOf (\_S3)) { // Return (Package (0x02) { 0x22, 0x03 }) //} Else { Return (Package (0x02) { 0x22, 0x01 }) |