diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-12-02 21:04:13 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-12-03 13:01:49 +0100 |
| commit | b6435610f579bc53022ec9719f03bb3d75e4594a (patch) | |
| tree | 7e4a7bb08a273c02620bf223ebc55a91eae483a7 /src/mainboard/hp | |
| parent | 29635415a6fadbd9d7bc9b7738babe67f0702db3 (diff) | |
| download | coreboot-b6435610f579bc53022ec9719f03bb3d75e4594a.tar.xz | |
mainboard/hp/pavilion_m6_1035dx: Remove HUDSON_LEGACY_FREE
The Embedded Controller sits behind the LPC bridge and so needs
LPC decodes to be enabled.
Remove the LPC decode enable out of agesawrapper.c. The enable
is in fact done in: 'VOID FchInitResetLpcProgram(IN VOID *FchDataPtr)'
which writes the magic '0xFF03FFD5' to register 0x44 of the PCI 14.3
LPC Bridge to enable LPC decodes when HUDSON_LEGACY_FREE is not defined.
Change-Id: Ia487d21faa0fceb2557dbce14ef8822116fada91
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7628
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/mainboard/hp')
| -rw-r--r-- | src/mainboard/hp/pavilion_m6_1035dx/Kconfig | 4 | ||||
| -rw-r--r-- | src/mainboard/hp/pavilion_m6_1035dx/romstage.c | 4 |
2 files changed, 0 insertions, 8 deletions
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig index 12e0579c6d..30e50c1007 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig +++ b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig @@ -69,8 +69,4 @@ config VGA_BIOS_ID string default "1002,9900" -config HUDSON_LEGACY_FREE - bool - default y - endif # BOARD_HP_PAVILION_M6_1035DX diff --git a/src/mainboard/hp/pavilion_m6_1035dx/romstage.c b/src/mainboard/hp/pavilion_m6_1035dx/romstage.c index 9411ac87e2..d142a9d754 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/romstage.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/romstage.c @@ -40,10 +40,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) u32 val; agesawrapper_amdinitmmio(); - /* Set LPC decode enables. */ - pci_devfn_t dev = PCI_DEV(0, 0x14, 3); - pci_write_config32(dev, 0x44, 0xff03ffd5); - hudson_lpc_port80(); if (!cpu_init_detectedx && boot_cpu()) { |