summaryrefslogtreecommitdiff
path: root/src/mainboard/intel/cannonlake_rvp
diff options
context:
space:
mode:
authorWim Vervoorn <wvervoorn@eltan.com>2019-12-11 11:54:33 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-12-16 09:50:55 +0000
commit116a837818897d5f1f0c76021d48532133e8f5f6 (patch)
treefa023295e4dc900dd0eeb5bce2228260dbd4a14c /src/mainboard/intel/cannonlake_rvp
parent03f78b069d4f4fe0aa2a3ec67117e0c478da3b72 (diff)
downloadcoreboot-116a837818897d5f1f0c76021d48532133e8f5f6.tar.xz
mb: Use fixed value in RcompTarget structure
Now RCOMP_TARGET_PARAMS is defined and used once in the definition of the RcompTarget structure. All other structures in these functions use a fixed value. Replace RCOMP_TARGET_PARAMS with fixed value. BUG=N/A TEST=build Change-Id: Ibe7c72c65975354433e9a0c613bda715eb782412 Signed-off-by: Wim Vervoorn <wvervoorn@eltan.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37658 Reviewed-by: Frans Hendriks <fhendriks@eltan.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/intel/cannonlake_rvp')
-rw-r--r--src/mainboard/intel/cannonlake_rvp/spd/spd.h2
-rw-r--r--src/mainboard/intel/cannonlake_rvp/spd/spd_util.c3
2 files changed, 1 insertions, 4 deletions
diff --git a/src/mainboard/intel/cannonlake_rvp/spd/spd.h b/src/mainboard/intel/cannonlake_rvp/spd/spd.h
index 128eb64a3c..4193e9cb2f 100644
--- a/src/mainboard/intel/cannonlake_rvp/spd/spd.h
+++ b/src/mainboard/intel/cannonlake_rvp/spd/spd.h
@@ -17,8 +17,6 @@
#ifndef MAINBOARD_SPD_H
#define MAINBOARD_SPD_H
-#define RCOMP_TARGET_PARAMS 0x5
-
void mainboard_fill_dq_map_ch0(void *dq_map_ptr);
void mainboard_fill_dq_map_ch1(void *dq_map_ptr);
void mainboard_fill_dqs_map_ch0(void *dqs_map_ptr);
diff --git a/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c b/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c
index 0c2f74781b..2499b32e2d 100644
--- a/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c
+++ b/src/mainboard/intel/cannonlake_rvp/spd/spd_util.c
@@ -73,8 +73,7 @@ void mainboard_fill_rcomp_res_data(void *rcomp_ptr)
void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr)
{
/* Rcomp target */
- static const u16 RcompTarget[RCOMP_TARGET_PARAMS] = {
- 80, 40, 40, 40, 30 };
+ static const u16 RcompTarget[5] = { 80, 40, 40, 40, 30 };
memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget));
}