diff options
| author | Furquan Shaikh <furquan@google.com> | 2018-06-29 11:50:29 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2018-07-03 04:05:06 +0000 |
| commit | 26475572a7a823d72284cedf8bf09f336ba26379 (patch) | |
| tree | dbbbbe1ea9b3a56c5dd1c60906267bb7676b83d0 /src/mainboard/intel | |
| parent | 54c2cc1b29a9b2e1a80f5b32d46914a4a801fe67 (diff) | |
| download | coreboot-26475572a7a823d72284cedf8bf09f336ba26379.tar.xz | |
mb/intel/glkrvp: Get rid of DRIVERS_PS2_KEYBOARD selection
Until now, chromeec was doing keyboard initialization for the boards
that have DRIVERS_PS2_KEYBOARD selected. However, coreboot does not
leave the keyboard controller in a default reset state. This could
result in payloads or OS failing to probe the controller as there
could be stale data buffered in the controller during the handoff.
Since the boards using chromeec already perform keyboard
initialization in payload, there is no need to initialize the
keyboard in coreboot too. This change gets rid of DRIVERS_PS2_KEYBOARD
selection from all google mainboards using chromeec.
BUG=b:110024487
Change-Id: I9af48e648231c18f98d0cc1ddd178b8d00082b0a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/27292
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard/intel')
| -rw-r--r-- | src/mainboard/intel/glkrvp/Kconfig | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index eb6d595fcc..948455920a 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -5,7 +5,6 @@ config BOARD_INTEL_BASEBOARD_GLKRVP select BOARD_ROMSIZE_KB_16384 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID - select DRIVERS_PS2_KEYBOARD select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select MAINBOARD_HAS_CHROMEOS |