diff options
| author | Peter Lemenkov <lemenkov@gmail.com> | 2019-12-26 21:02:24 +0300 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-12-31 15:21:11 +0000 |
| commit | 2450a7e72475fb98c3fa9d643cbc00f74f688fde (patch) | |
| tree | b2baba9391727c00b56366a69c740df1aabd6fc9 /src/mainboard/intel | |
| parent | 2e5f1f7e9400c5187a176958a7babd424eb158ba (diff) | |
| download | coreboot-2450a7e72475fb98c3fa9d643cbc00f74f688fde.tar.xz | |
mb/*/*/acpi_tables: Don't zero out gnvs again
The gnvs structure was zeroed out before calling acpi_create_gnvs(...)
in the following files:
* src/southbridge/intel/*/lpc.c
Change-Id: Id7755b1e4b8f5cb8abd1f411b5dc174b6beee21c
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37956
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/intel')
| -rw-r--r-- | src/mainboard/intel/dg41wv/acpi_tables.c | 2 | ||||
| -rw-r--r-- | src/mainboard/intel/dg43gt/acpi_tables.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/intel/dg41wv/acpi_tables.c b/src/mainboard/intel/dg41wv/acpi_tables.c index 666bba63e3..c607c32326 100644 --- a/src/mainboard/intel/dg41wv/acpi_tables.c +++ b/src/mainboard/intel/dg41wv/acpi_tables.c @@ -20,8 +20,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { - memset((void *)gnvs, 0, sizeof(*gnvs)); - gnvs->pwrs = 1; /* Power state (AC = 1) */ gnvs->cmap = 0x01; /* Enable COM 1 port */ } diff --git a/src/mainboard/intel/dg43gt/acpi_tables.c b/src/mainboard/intel/dg43gt/acpi_tables.c index d609a0e1d9..1ab4139106 100644 --- a/src/mainboard/intel/dg43gt/acpi_tables.c +++ b/src/mainboard/intel/dg43gt/acpi_tables.c @@ -20,8 +20,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { - memset((void *)gnvs, 0, sizeof(*gnvs)); - gnvs->pwrs = 1; /* Power state (AC = 1) */ gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */ gnvs->apic = 1; /* Enable APIC */ |