diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2013-11-23 19:22:53 -0600 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-12-02 22:11:20 +0100 |
| commit | 72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (patch) | |
| tree | 0201395e975f173ebc8badcc952598d559e8a745 /src/mainboard/kontron | |
| parent | bcfcfa4473357eb6272bc8bcc5e03f4ba517bcd2 (diff) | |
| download | coreboot-72dccce0c9a7cf59ca51a3174fc11eb8899e1761.tar.xz | |
global: Fix usage of get_option() to make use of CB_CMOS_ codes
Do not directly check the return value of get_option, but instead compare
the returned value against a CB_CMOS_ error code, or against CB_SUCCESS.
Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4266
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/kontron')
| -rw-r--r-- | src/mainboard/kontron/986lcd-m/mainboard.c | 12 | ||||
| -rw-r--r-- | src/mainboard/kontron/ktqm77/mainboard.c | 4 |
2 files changed, 8 insertions, 8 deletions
diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index 0bee70e1ee..f4e1a24b22 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -124,18 +124,18 @@ static void hwm_setup(void) int cpufan_speed = 0, sysfan_speed = 0; int cpufan_temperature = 0, sysfan_temperature = 0; - if (get_option(&cpufan_control, "cpufan_cruise_control") < 0) + if (get_option(&cpufan_control, "cpufan_cruise_control") != CB_SUCCESS) cpufan_control = FAN_CRUISE_CONTROL_DISABLED; - if (get_option(&cpufan_speed, "cpufan_speed") < 0) + if (get_option(&cpufan_speed, "cpufan_speed") != CB_SUCCESS) cpufan_speed = FAN_SPEED_5625; - //if (get_option(&cpufan_temperature, "cpufan_temperature") < 0) + //if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS) // cpufan_temperature = FAN_TEMPERATURE_30DEGC; - if (get_option(&sysfan_control, "sysfan_cruise_control") < 0) + if (get_option(&sysfan_control, "sysfan_cruise_control") != CB_SUCCESS) sysfan_control = FAN_CRUISE_CONTROL_DISABLED; - if (get_option(&sysfan_speed, "sysfan_speed") < 0) + if (get_option(&sysfan_speed, "sysfan_speed") != CB_SUCCESS) sysfan_speed = FAN_SPEED_5625; - //if (get_option(&sysfan_temperature, "sysfan_temperature") < 0) + //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS) // sysfan_temperature = FAN_TEMPERATURE_30DEGC; // hwm_write(0x31, 0x20); // AVCC high limit diff --git a/src/mainboard/kontron/ktqm77/mainboard.c b/src/mainboard/kontron/ktqm77/mainboard.c index 3829d72669..30f0468ef3 100644 --- a/src/mainboard/kontron/ktqm77/mainboard.c +++ b/src/mainboard/kontron/ktqm77/mainboard.c @@ -163,7 +163,7 @@ static void mainboard_enable(device_t dev) verb_setup(); unsigned disable = 0; - if ((get_option(&disable, "ethernet1") == 0) && disable) { + if ((get_option(&disable, "ethernet1") == CB_SUCCESS) && disable) { device_t nic = dev_find_slot(0, PCI_DEVFN(0x1c, 2)); if (nic) { printk(BIOS_DEBUG, "DISABLE FIRST NIC!\n"); @@ -171,7 +171,7 @@ static void mainboard_enable(device_t dev) } } disable = 0; - if ((get_option(&disable, "ethernet2") == 0) && disable) { + if ((get_option(&disable, "ethernet2") == CB_SUCCESS) && disable) { device_t nic = dev_find_slot(0, PCI_DEVFN(0x1c, 3)); if (nic) { printk(BIOS_DEBUG, "DISABLE SECOND NIC!\n"); |