diff options
| author | Patrick Rudolph <siro@das-labor.org> | 2017-04-28 17:28:32 +0200 |
|---|---|---|
| committer | Patrick Rudolph <siro@das-labor.org> | 2017-05-21 16:38:52 +0200 |
| commit | c670a41ca717aefced613aa304da0e95ae4f2a27 (patch) | |
| tree | 4249645aa69a049ac668a87050a64ac444bad3da /src/mainboard/lenovo/s230u | |
| parent | ac27d3688a862074631e3a1390caf85c068d55cb (diff) | |
| download | coreboot-c670a41ca717aefced613aa304da0e95ae4f2a27.tar.xz | |
mb/lenvovo/*: Clean mainboard.c and devicetree
* Move board specific SPI registers to devicetree
* Remove unused headers
* Remove obsolete methods
* Fix coding style
* Fix Thinkpad L520 SPI lvscc register
Except for Thinkpad L520, no functional change has been done,
just moving stuff around.
Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/19494
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/lenovo/s230u')
| -rw-r--r-- | src/mainboard/lenovo/s230u/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/lenovo/s230u/mainboard.c | 8 |
2 files changed, 4 insertions, 8 deletions
diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index b9b38ddca2..35135a91c6 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -56,6 +56,10 @@ chip northbridge/intel/sandybridge register "superspeed_capable_ports" = "0x0000000f" register "xhci_overcurrent_mapping" = "0x00000c03" register "xhci_switchable_ports" = "0x0000000f" + + register "spi_uvscc" = "0x2005" + register "spi_lvscc" = "0x2005" + device pci 14.0 on # USB 3.0 Controller subsystemid 0x17aa 0x2205 end diff --git a/src/mainboard/lenovo/s230u/mainboard.c b/src/mainboard/lenovo/s230u/mainboard.c index ace72e531b..a1b63cc1e8 100644 --- a/src/mainboard/lenovo/s230u/mainboard.c +++ b/src/mainboard/lenovo/s230u/mainboard.c @@ -20,7 +20,6 @@ #include <console/console.h> #include <drivers/intel/gma/int15.h> #include <ec/acpi/ec.h> -#include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> #include <string.h> #include <smbios.h> @@ -28,12 +27,6 @@ #include <arch/acpi.h> -static void mainboard_init(device_t dev) -{ - RCBA32(0x38c8) = 0x00002005; - RCBA32(0x38c4) = 0x00802005; -} - static u8 mainboard_fill_ec_version(char *buf, u8 buf_len) { u8 i, c; @@ -74,7 +67,6 @@ static void mainboard_smbios_strings( static void mainboard_enable(device_t dev) { - dev->ops->init = mainboard_init; dev->ops->get_smbios_strings = mainboard_smbios_strings, install_intel_vga_int15_handler( |