summaryrefslogtreecommitdiff
path: root/src/mainboard/lenovo/t430
diff options
context:
space:
mode:
authorPeter Lemenkov <lemenkov@gmail.com>2020-02-06 20:31:07 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-03-06 08:03:02 +0000
commit0c526386f445de72c7790ea9aef041c90ee14ff9 (patch)
treeb39b2481d6461ba62e9a0fec18638c15bdf8d7cf /src/mainboard/lenovo/t430
parentb2ecc572de7b9c1c0a44f59bc5af22e0bccfc9bb (diff)
downloadcoreboot-0c526386f445de72c7790ea9aef041c90ee14ff9.tar.xz
mb/lenovo: Remove thermal.h header
We include it only in one file. So let's simplify everything and do like autoport does. Change-Id: I71f092ed7582b4931122d72f41d0b42a7569b96e Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38781 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/mainboard/lenovo/t430')
-rw-r--r--src/mainboard/lenovo/t430/acpi_tables.c17
-rw-r--r--src/mainboard/lenovo/t430/thermal.h44
2 files changed, 10 insertions, 51 deletions
diff --git a/src/mainboard/lenovo/t430/acpi_tables.c b/src/mainboard/lenovo/t430/acpi_tables.c
index ea7e52f0e8..82ddd9f269 100644
--- a/src/mainboard/lenovo/t430/acpi_tables.c
+++ b/src/mainboard/lenovo/t430/acpi_tables.c
@@ -14,17 +14,20 @@
*/
#include <southbridge/intel/bd82x6x/nvs.h>
-#include "thermal.h"
void acpi_create_gnvs(global_nvs_t *gnvs)
{
- // the lid is open by default.
+ /* The lid is open by default */
gnvs->lids = 1;
- gnvs->f0of = CTDP_DOWN_THRESHOLD_OFF;
- gnvs->f0on = CTDP_DOWN_THRESHOLD_ON;
+ /* Config TDP Down */
+ gnvs->f0of = 80;
+ gnvs->f0on = 90;
- gnvs->tcrt = CRITICAL_TEMPERATURE;
- gnvs->tpsv = PASSIVE_TEMPERATURE;
- gnvs->tmax = MAX_TEMPERATURE;
+ /* Temperature at which OS will shutdown */
+ gnvs->tcrt = 100;
+ /* Temperature at which OS will throttle CPU */
+ gnvs->tpsv = 90;
+ /* Tj_max value for calculating PECI CPU temperature */
+ gnvs->tmax = 105;
}
diff --git a/src/mainboard/lenovo/t430/thermal.h b/src/mainboard/lenovo/t430/thermal.h
deleted file mode 100644
index edfe3bc7ce..0000000000
--- a/src/mainboard/lenovo/t430/thermal.h
+++ /dev/null
@@ -1,44 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2008-2009 coresystems GmbH
- * Copyright (C) 2011 The Chromium OS Authors. All rights reserved.
- * Copyright (C) 2014 Vladimir Serbinenko
- * Copyright (C) 2016 Patrick Rudolph <siro@das-labor.org>
- * Copyright (C) 2017 James Ye <jye836@gmail.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#ifndef MAINBOARD_THERMAL_H
-#define MAINBOARD_THERMAL_H
-
-/* Config TDP Sensor ID */
-#define CTDP_SENSOR_ID 0 /* PECI */
-
-/* Config TDP Nominal */
-#define CTDP_NOMINAL_THRESHOLD_OFF 0
-#define CTDP_NOMINAL_THRESHOLD_ON 0
-
-/* Config TDP Down */
-#define CTDP_DOWN_THRESHOLD_OFF 80
-#define CTDP_DOWN_THRESHOLD_ON 90
-
-/* Temperature which OS will shutdown at */
-#define CRITICAL_TEMPERATURE 100
-
-/* Temperature which OS will throttle CPU */
-#define PASSIVE_TEMPERATURE 90
-
-/* Tj_max value for calculating PECI CPU temperature */
-#define MAX_TEMPERATURE 105
-
-#endif /* MAINBOARD_THERMAL_H */