summaryrefslogtreecommitdiff
path: root/src/mainboard/lenovo/t60
diff options
context:
space:
mode:
authorPeter Lemenkov <lemenkov@gmail.com>2018-10-10 14:28:44 +0200
committerPhilipp Deppenwiese <zaolin.daisuki@gmail.com>2019-05-25 12:10:49 +0000
commita6f9ee39065ecd6ec24f5f09616bddef17e894d6 (patch)
tree9773e15d2084a1ccaaafec42969c6fbfcc2f7762 /src/mainboard/lenovo/t60
parent43f6d9d7160be96460f77993465de1570568c569 (diff)
downloadcoreboot-a6f9ee39065ecd6ec24f5f09616bddef17e894d6.tar.xz
mb/lenovo: Unify thermal threshold handling
Unify thermal handling across Lenovo boards (except g505, which is different). Namely, do the following: * Move thermal levels from acpi_tables to thermal.h (and create if necessary). * Don't use board-specific ifdef guards. * Set thermal levels using dedicated acpi_update_thermal_table function as almost all Lenovo boards do. * Update list of authors in comments. Merge all author's entries. * Minor whitespace and formatting. This makes diff -ruw between the Lenovo boards smaller. Change-Id: If569f67c932b7fbf14893b890a5588df4994daeb Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/29659 Reviewed-by: Patrick Rudolph <siro@das-labor.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/lenovo/t60')
-rw-r--r--src/mainboard/lenovo/t60/acpi_tables.c11
-rw-r--r--src/mainboard/lenovo/t60/thermal.h30
2 files changed, 38 insertions, 3 deletions
diff --git a/src/mainboard/lenovo/t60/acpi_tables.c b/src/mainboard/lenovo/t60/acpi_tables.c
index 183b7fe299..bd10a0e3fb 100644
--- a/src/mainboard/lenovo/t60/acpi_tables.c
+++ b/src/mainboard/lenovo/t60/acpi_tables.c
@@ -16,6 +16,13 @@
#include <stdint.h>
#include <southbridge/intel/i82801gx/nvs.h>
+#include "thermal.h"
+
+static void acpi_update_thermal_table(global_nvs_t *gnvs)
+{
+ gnvs->tcrt = CRITICAL_TEMPERATURE;
+ gnvs->tpsv = PASSIVE_TEMPERATURE;
+}
void acpi_create_gnvs(global_nvs_t *gnvs)
{
@@ -23,7 +30,5 @@ void acpi_create_gnvs(global_nvs_t *gnvs)
gnvs->cmap = 0x01;
gnvs->cmbp = 0x01;
- /* Set thermal levels */
- gnvs->tcrt = 100;
- gnvs->tpsv = 90;
+ acpi_update_thermal_table(gnvs);
}
diff --git a/src/mainboard/lenovo/t60/thermal.h b/src/mainboard/lenovo/t60/thermal.h
new file mode 100644
index 0000000000..72953fd2c2
--- /dev/null
+++ b/src/mainboard/lenovo/t60/thermal.h
@@ -0,0 +1,30 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2008-2009 coresystems GmbH
+ * Copyright (C) 2011 The Chromium OS Authors. All rights reserved.
+ * Copyright (C) 2014 Vladimir Serbinenko
+ * Copyright (C) 2016 Patrick Rudolph <siro@das-labor.org>
+ * Copyright (C) 2017 James Ye <jye836@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; version 2 of
+ * the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef MAINBOARD_THERMAL_H
+#define MAINBOARD_THERMAL_H
+
+/* Temperature which OS will shutdown at */
+#define CRITICAL_TEMPERATURE 100
+
+/* Temperature which OS will throttle CPU */
+#define PASSIVE_TEMPERATURE 90
+
+#endif /* MAINBOARD_THERMAL_H */