summaryrefslogtreecommitdiff
path: root/src/mainboard/lenovo/x230
diff options
context:
space:
mode:
authorPatrick Rudolph <siro@das-labor.org>2017-04-28 17:28:32 +0200
committerPatrick Rudolph <siro@das-labor.org>2017-05-21 16:38:52 +0200
commitc670a41ca717aefced613aa304da0e95ae4f2a27 (patch)
tree4249645aa69a049ac668a87050a64ac444bad3da /src/mainboard/lenovo/x230
parentac27d3688a862074631e3a1390caf85c068d55cb (diff)
downloadcoreboot-c670a41ca717aefced613aa304da0e95ae4f2a27.tar.xz
mb/lenvovo/*: Clean mainboard.c and devicetree
* Move board specific SPI registers to devicetree * Remove unused headers * Remove obsolete methods * Fix coding style * Fix Thinkpad L520 SPI lvscc register Except for Thinkpad L520, no functional change has been done, just moving stuff around. Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Signed-off-by: Patrick Rudolph <siro@das-labor.org> Reviewed-on: https://review.coreboot.org/19494 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/lenovo/x230')
-rw-r--r--src/mainboard/lenovo/x230/devicetree.cb3
-rw-r--r--src/mainboard/lenovo/x230/mainboard.c23
2 files changed, 6 insertions, 20 deletions
diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb
index a8341fc2ea..a1b0662671 100644
--- a/src/mainboard/lenovo/x230/devicetree.cb
+++ b/src/mainboard/lenovo/x230/devicetree.cb
@@ -79,6 +79,9 @@ chip northbridge/intel/sandybridge
register "c2_latency" = "101" # c2 not supported
register "p_cnt_throttling_supported" = "1"
+ register "spi_uvscc" = "0x2005"
+ register "spi_lvscc" = "0x2005"
+
device pci 14.0 on
subsystemid 0x17aa 0x21fa
end # USB 3.0 Controller
diff --git a/src/mainboard/lenovo/x230/mainboard.c b/src/mainboard/lenovo/x230/mainboard.c
index a9b6392a81..0114e9be2a 100644
--- a/src/mainboard/lenovo/x230/mainboard.c
+++ b/src/mainboard/lenovo/x230/mainboard.c
@@ -15,35 +15,18 @@
* GNU General Public License for more details.
*/
-#include <types.h>
-#include <string.h>
#include <device/device.h>
-#include <device/pci_def.h>
-#include <device/pci_ops.h>
-#include <console/console.h>
#include <drivers/intel/gma/int15.h>
-#include <arch/acpi.h>
-#include <boot/coreboot_tables.h>
-#include <southbridge/intel/bd82x6x/pch.h>
-#include <smbios.h>
-#include <device/pci.h>
-#include <pc80/keyboard.h>
#include <ec/lenovo/h8/h8.h>
-static void mainboard_init(device_t dev)
-{
- RCBA32(0x38c8) = 0x00002005;
- RCBA32(0x38c4) = 0x00802005;
-}
-
// mainboard_enable is executed as first thing after
// enumerate_buses().
static void mainboard_enable(device_t dev)
{
- dev->ops->init = mainboard_init;
-
- install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
+ install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
+ GMA_INT15_PANEL_FIT_DEFAULT,
+ GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
}
void h8_mainboard_init_dock (void)