summaryrefslogtreecommitdiff
path: root/src/mainboard/lenovo
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-02-11 13:42:20 +0100
committerAngel Pons <th3fanbus@gmail.com>2021-02-12 19:48:26 +0000
commit33b59c9170a66a7f6d9c26ccf664714ea81d218d (patch)
treef5b71768d08472e1f2f5bea638099601b8e24a37 /src/mainboard/lenovo
parent3b0a4899d8ded1ee9bec1d431d91f431291e3eb0 (diff)
downloadcoreboot-33b59c9170a66a7f6d9c26ccf664714ea81d218d.tar.xz
haswell: Drop `mainboard_fill_pei_data`
Use global variables to provide mainboard USB settings, and have the northbridge code copy it into the `pei_data` struct. For now. To minimize diffstat noise, this patch does not reindent the now-global mainboard USB configuration arrays. This is cleaned up in a follow-up. Change-Id: I273c7a6cd46734ae25b95fc11b5e188d63cac32e Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50538 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/lenovo')
-rw-r--r--src/mainboard/lenovo/t440p/romstage.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c
index 3e5cc0d65d..eaee7348f1 100644
--- a/src/mainboard/lenovo/t440p/romstage.c
+++ b/src/mainboard/lenovo/t440p/romstage.c
@@ -46,9 +46,7 @@ void mb_get_spd_map(uint8_t spd_map[4])
spd_map[2] = 0xa2;
}
-void mainboard_fill_pei_data(struct pei_data *pei_data)
-{
- struct usb2_port_setting usb2_ports[MAX_USB2_PORTS] = {
+ const struct usb2_port_setting mainboard_usb2_ports[MAX_USB2_PORTS] = {
/* Length, Enable, OCn#, Location */
{ 0x0040, 1, 0, USB_PORT_BACK_PANEL }, /* USB3 */
{ 0x0040, 1, 0, USB_PORT_BACK_PANEL }, /* USB3 */
@@ -66,7 +64,7 @@ void mainboard_fill_pei_data(struct pei_data *pei_data)
{ 0x0040, 1, 6, USB_PORT_BACK_PANEL },
};
- struct usb3_port_setting usb3_ports[MAX_USB3_PORTS] = {
+ const struct usb3_port_setting mainboard_usb3_ports[MAX_USB3_PORTS] = {
{ 1, 0 },
{ 1, 0 },
{ 1, USB_OC_PIN_SKIP },
@@ -74,7 +72,3 @@ void mainboard_fill_pei_data(struct pei_data *pei_data)
{ 1, 1 },
{ 1, 1 }, /* WWAN */
};
-
- memcpy(pei_data->usb2_ports, usb2_ports, sizeof(usb2_ports));
- memcpy(pei_data->usb3_ports, usb3_ports, sizeof(usb3_ports));
-}