summaryrefslogtreecommitdiff
path: root/src/mainboard/lenovo
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2017-03-24 11:08:32 -0600
committerMartin Roth <martinroth@google.com>2017-03-26 04:32:05 +0200
commit5ef5c00704ac902f33f52e8daa4f3167cf1000ba (patch)
tree5fffcc411abf879de4c10de29023ac3ccb2053e7 /src/mainboard/lenovo
parentf0eda827b82d1989ec860e82aeb1a8b81616b356 (diff)
downloadcoreboot-5ef5c00704ac902f33f52e8daa4f3167cf1000ba.tar.xz
mb/lenovo/s230u: Fix USBDEBUG check
- Change preprocessor #if to standard C if. This will get optimized out if the config option is disabled, but lets the compiler check the contents. - CONFIG_USBDEBUG is always going to be defined even if it's disabled, so this check is not going to work as expected. See the coreboot Kconfig documentation in /Documentation/core/Kconfig.md Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/18974 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/mainboard/lenovo')
-rw-r--r--src/mainboard/lenovo/s230u/romstage.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/mainboard/lenovo/s230u/romstage.c b/src/mainboard/lenovo/s230u/romstage.c
index ce751653c2..ad5f02187f 100644
--- a/src/mainboard/lenovo/s230u/romstage.c
+++ b/src/mainboard/lenovo/s230u/romstage.c
@@ -51,10 +51,9 @@ void pch_enable_lpc(void)
CONFIG_EC_BASE_ADDRESS | 1);
pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xd8, 0xffc0);
- #ifdef CONFIG_USBDEBUG
/* Enable external USB port power. */
- ec_mm_set_bit(0x3b, 4);
- #endif
+ if (IS_ENABLED(CONFIG_USBDEBUG))
+ ec_mm_set_bit(0x3b, 4);
}
void rcba_config(void)