summaryrefslogtreecommitdiff
path: root/src/mainboard/lenovo
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-11-12 16:17:26 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-11-18 07:06:13 +0000
commitdc2e7c6e0fb1331a7808c226992c71e07f9ca7bd (patch)
treef1bde11a320b587f99bc3a62e654ab1be346ea24 /src/mainboard/lenovo
parent05d7d82d37ae04ec4cf3579eb1c0f7bf0c0b7aa2 (diff)
downloadcoreboot-dc2e7c6e0fb1331a7808c226992c71e07f9ca7bd.tar.xz
nb/intel/sandybridge: Make the mainboard_early_init hook optional
This adds an empty weakly linked default. The rationale behind this change is that without the callback some features might not work but that the result is likely still able to boot, so it can be made optional. Change-Id: I62c8010aa81fc45d208e9293feb2f45b45f34a82 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36780 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/lenovo')
-rw-r--r--src/mainboard/lenovo/l520/romstage.c4
-rw-r--r--src/mainboard/lenovo/s230u/romstage.c4
-rw-r--r--src/mainboard/lenovo/t430s/variants/t431s/romstage.c4
-rw-r--r--src/mainboard/lenovo/x131e/romstage.c4
-rw-r--r--src/mainboard/lenovo/x1_carbon_gen1/romstage.c4
-rw-r--r--src/mainboard/lenovo/x220/romstage.c4
-rw-r--r--src/mainboard/lenovo/x230/romstage.c4
7 files changed, 0 insertions, 28 deletions
diff --git a/src/mainboard/lenovo/l520/romstage.c b/src/mainboard/lenovo/l520/romstage.c
index 82f63776d9..fc67e5adcf 100644
--- a/src/mainboard/lenovo/l520/romstage.c
+++ b/src/mainboard/lenovo/l520/romstage.c
@@ -47,10 +47,6 @@ const struct southbridge_usb_port mainboard_usb_ports[] = {
{ 1, 0, -1 },
};
-void mainboard_early_init(int s3resume)
-{
-}
-
void mainboard_config_superio(void)
{
}
diff --git a/src/mainboard/lenovo/s230u/romstage.c b/src/mainboard/lenovo/s230u/romstage.c
index 754c49aa4f..48d26c2519 100644
--- a/src/mainboard/lenovo/s230u/romstage.c
+++ b/src/mainboard/lenovo/s230u/romstage.c
@@ -64,10 +64,6 @@ const struct southbridge_usb_port mainboard_usb_ports[] = {
{ 1, 1, 6 },
};
-void mainboard_early_init(int s3resume)
-{
-}
-
void mainboard_config_superio(void)
{
}
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c
index e7b43db487..3f62f06c58 100644
--- a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c
+++ b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c
@@ -54,7 +54,3 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
memcpy(&spd[0], spd_file, spd_file_len);
read_spd(&spd[2], 0x51, id_only);
}
-
-void mainboard_early_init(int s3resume)
-{
-}
diff --git a/src/mainboard/lenovo/x131e/romstage.c b/src/mainboard/lenovo/x131e/romstage.c
index 2a6ee2733b..6f176c78f7 100644
--- a/src/mainboard/lenovo/x131e/romstage.c
+++ b/src/mainboard/lenovo/x131e/romstage.c
@@ -51,10 +51,6 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
read_spd(&spd[2], 0x52, id_only);
}
-void mainboard_early_init(int s3resume)
-{
-}
-
void mainboard_config_superio(void)
{
}
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c
index b779c4eff5..eb2a5b19f5 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c
+++ b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c
@@ -104,10 +104,6 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
memcpy(&spd[2], memory, 256);
}
-void mainboard_early_init(int s3resume)
-{
-}
-
void mainboard_config_superio(void)
{
}
diff --git a/src/mainboard/lenovo/x220/romstage.c b/src/mainboard/lenovo/x220/romstage.c
index af92f9ba8e..8460208ddb 100644
--- a/src/mainboard/lenovo/x220/romstage.c
+++ b/src/mainboard/lenovo/x220/romstage.c
@@ -91,10 +91,6 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
read_spd (&spd[2], 0x51, id_only);
}
-void mainboard_early_init(int s3resume)
-{
-}
-
void mainboard_config_superio(void)
{
}
diff --git a/src/mainboard/lenovo/x230/romstage.c b/src/mainboard/lenovo/x230/romstage.c
index 60016a4f07..6f1013567b 100644
--- a/src/mainboard/lenovo/x230/romstage.c
+++ b/src/mainboard/lenovo/x230/romstage.c
@@ -56,10 +56,6 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
read_spd (&spd[2], 0x51, id_only);
}
-void mainboard_early_init(int s3resume)
-{
-}
-
void mainboard_config_superio(void)
{
}