diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-12-06 18:17:01 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-12-06 18:17:01 +0000 |
| commit | 9b9791c29d0f4e88127f59bb87d53cfed65cd912 (patch) | |
| tree | 40ee30e72f4cfd015bafc59a642f1f69959a9d83 /src/mainboard/msi/ms6178 | |
| parent | 29cb06abca665954e910f91397957ec93c627e86 (diff) | |
| download | coreboot-9b9791c29d0f4e88127f59bb87d53cfed65cd912.tar.xz | |
Winbond W83627HF: Use existing functions instead of open-coding.
Use w83627hf_set_clksel_48() where needed instead or open-coding the same
functionality, and also use w83627hf_enable_serial() instead of
w83627hf_enable_dev() (which does exactly the same, but isn't wrapped in the
enter/exit config mode functions).
Abuild-tested.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6143 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard/msi/ms6178')
| -rw-r--r-- | src/mainboard/msi/ms6178/romstage.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/mainboard/msi/ms6178/romstage.c b/src/mainboard/msi/ms6178/romstage.c index 30bddde5ac..19d4c81488 100644 --- a/src/mainboard/msi/ms6178/romstage.c +++ b/src/mainboard/msi/ms6178/romstage.c @@ -33,18 +33,15 @@ #include <lib.h> #define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1) +#define DUMMY_DEV PNP_DEV(0x2e, 0) void enable_smbus(void); int smbus_read_byte(u8 device, u8 address); void main(unsigned long bist) { - /* FIXME */ - outb(0x87, 0x2e); - outb(0x87, 0x2e); - pnp_write_config(SERIAL_DEV, 0x24, 0x84 | (1 << 6)); + w83627hf_set_clksel_48(DUMMY_DEV); w83627hf_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); - outb(0x87, 0xaa); uart_init(); console_init(); |