diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2008-11-11 14:26:03 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2008-11-11 14:26:03 +0000 |
| commit | 3b6c527322259d6ae7878411ca26ee6dd9374b3c (patch) | |
| tree | 9e4b8603e0864aff57aa0642ca4e5e119191904f /src/mainboard/msi | |
| parent | 779b3e312901d4ef533d5cc13f551bab2823de08 (diff) | |
| download | coreboot-3b6c527322259d6ae7878411ca26ee6dd9374b3c.tar.xz | |
Always enable serial before SMBus (or as early as possible), as the SMBus
enable may do printk()s which result in a 2 minute delay on some boards.
Fix this on all boards which currently do smbus_enable() before enabling
the serial console.
Thanks to Elia Yehuda <z4ziggy@gmail.com> for tracking this bug down.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3742 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard/msi')
| -rw-r--r-- | src/mainboard/msi/ms6178/auto.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/mainboard/msi/ms6178/auto.c b/src/mainboard/msi/ms6178/auto.c index 0ae4e0a1b8..d92aa6b53b 100644 --- a/src/mainboard/msi/ms6178/auto.c +++ b/src/mainboard/msi/ms6178/auto.c @@ -53,8 +53,6 @@ static void main(unsigned long bist) if (bist == 0) early_mtrr_init(); - enable_smbus(); - /* FIXME */ outb(0x87, 0x2e); outb(0x87, 0x2e); @@ -64,6 +62,9 @@ static void main(unsigned long bist) uart_init(); console_init(); + + enable_smbus(); + report_bist_failure(bist); /* dump_spd_registers(&memctrl[0]); */ sdram_initialize(ARRAY_SIZE(memctrl), memctrl); |