diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2009-10-07 21:51:33 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2009-10-07 21:51:33 +0000 |
| commit | 95313d824dabcbdecaa74346a2d9e0ab2af9df9d (patch) | |
| tree | d6b73b9f65d3f12b833f66e968f5416bec092620 /src/mainboard/newisys | |
| parent | 17aeecab8988cb0fdb84a3269a65ff51c00a019a (diff) | |
| download | coreboot-95313d824dabcbdecaa74346a2d9e0ab2af9df9d.tar.xz | |
Major CONFIG_IRQ_TABLE_COUNT fixing and cleanups. Some of these boards
and PIRQ tables were actually wrong, I cannot imagine they ever
worked properly.
- Use CONFIG_IRQ_TABLE_COUNT in all irq_tables.c files instead of
hard-coded numbers.
- Make all CONFIG_IRQ_TABLE_COUNT values in irq_tables.c match Options.lb.
- Make all CONFIG_IRQ_TABLE_COUNT values match the actual number of entries
in the irq_tables.c file.
- Set all CONFIG_IRQ_SLOT_COUNT values in src/.../Options.lb for those
boards where they were set to 0 (in order to be overridden in
the respective targets/.../Config.lb).
This is mainly done to aid Patrick's scripts for kconfig conversion.
- Fix a number of comments in irq_tables.c files.
- Drop CONFIG_IRQ_SLOT_COUNT usage from boards that don't have irq_tables.c:
- tyan/s1846
- asus/a8v-e_se
- asus/m2v-mx_se
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4739 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard/newisys')
| -rw-r--r-- | src/mainboard/newisys/khepri/Options.lb | 2 | ||||
| -rw-r--r-- | src/mainboard/newisys/khepri/irq_tables.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/newisys/khepri/Options.lb b/src/mainboard/newisys/khepri/Options.lb index 9b7e07cd9b..266f7ba266 100644 --- a/src/mainboard/newisys/khepri/Options.lb +++ b/src/mainboard/newisys/khepri/Options.lb @@ -86,7 +86,7 @@ default CONFIG_HAVE_HARD_RESET=1 ## Build code to export a programmable irq routing table ## default CONFIG_HAVE_PIRQ_TABLE=1 -default CONFIG_IRQ_SLOT_COUNT=15 +default CONFIG_IRQ_SLOT_COUNT=9 ## ## Build code to export an x86 MP table diff --git a/src/mainboard/newisys/khepri/irq_tables.c b/src/mainboard/newisys/khepri/irq_tables.c index 37a652ef63..5baac5e46f 100644 --- a/src/mainboard/newisys/khepri/irq_tables.c +++ b/src/mainboard/newisys/khepri/irq_tables.c @@ -3,7 +3,7 @@ const struct irq_routing_table intel_irq_routing_table = { PIRQ_SIGNATURE, /* u32 signature */ PIRQ_VERSION, /* u16 version */ - 32+16*9, /* there can be total 9 devices on the bus */ + 32+16*CONFIG_IRQ_SLOT_COUNT, /* there can be total CONFIG_IRQ_SLOT_COUNT devices on the bus */ 1, /* Where the interrupt router lies (bus) */ (4<<3)|3, /* Where the interrupt router lies (dev) */ 0x0, /* IRQs devoted exclusively to PCI usage */ |