diff options
| author | Vladimir Serbinenko <phcoder@gmail.com> | 2014-10-31 09:16:31 +0100 |
|---|---|---|
| committer | Vladimir Serbinenko <phcoder@gmail.com> | 2015-05-28 08:27:10 +0200 |
| commit | dd2bc3f819ecb64a07f37c2a63621ecadd6b6ed8 (patch) | |
| tree | f611f100b307a2acc410a99726825e736d958e40 /src/mainboard/packardbell | |
| parent | f44ac13db26c5ab18ac2e35111acbf91841a2608 (diff) | |
| download | coreboot-dd2bc3f819ecb64a07f37c2a63621ecadd6b6ed8.tar.xz | |
igd.asl rewrite
Old igd.asl had inconsistent addresses (between _DOD and actual device)
and ghost devices. Any of those is enough to make brightness on windows
fail and make igd.asl out-of-ACPI-spec. Also old code favoured ridiculous
copying of the same thing 6 times per chipset. Leave only hooking up and
chipset-specific part in chipset directory. Move NVS handling and ACPI-spec
parts to a common file.
Change-Id: I556769e5e28b83e7465e3db689e26c8c0ab44757
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/7472
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <edward.ocallaghan@koparo.com>
Reviewed-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Diffstat (limited to 'src/mainboard/packardbell')
| -rw-r--r-- | src/mainboard/packardbell/ms2290/acpi/ec.asl | 4 | ||||
| -rw-r--r-- | src/mainboard/packardbell/ms2290/acpi_tables.c | 7 | ||||
| -rw-r--r-- | src/mainboard/packardbell/ms2290/devicetree.cb | 3 | ||||
| -rw-r--r-- | src/mainboard/packardbell/ms2290/dsdt.asl | 2 |
4 files changed, 5 insertions, 11 deletions
diff --git a/src/mainboard/packardbell/ms2290/acpi/ec.asl b/src/mainboard/packardbell/ms2290/acpi/ec.asl index 7a73a78e83..f06aba757d 100644 --- a/src/mainboard/packardbell/ms2290/acpi/ec.asl +++ b/src/mainboard/packardbell/ms2290/acpi/ec.asl @@ -121,12 +121,12 @@ Device(EC) /* Decrease brightness. */ Method(_Q1D, 0, NotSerialized) { - \_SB.PCI0.GFX0.LCD0.DECB() + \_SB.PCI0.GFX0.DECB() } /* Increase brightness. */ Method(_Q1C, 0, NotSerialized) { - \_SB.PCI0.GFX0.LCD0.INCB() + \_SB.PCI0.GFX0.INCB() } #include "battery.asl" diff --git a/src/mainboard/packardbell/ms2290/acpi_tables.c b/src/mainboard/packardbell/ms2290/acpi_tables.c index 001f488c36..73b9fff1b7 100644 --- a/src/mainboard/packardbell/ms2290/acpi_tables.c +++ b/src/mainboard/packardbell/ms2290/acpi_tables.c @@ -33,12 +33,5 @@ void acpi_create_gnvs(global_nvs_t * gnvs) { - /* IGD Displays */ - gnvs->ndid = 3; - gnvs->did[0] = 0x80000100; - gnvs->did[1] = 0x80000240; - gnvs->did[2] = 0x80000410; - gnvs->did[3] = 0x80000410; - gnvs->did[4] = 0x00000005; } diff --git a/src/mainboard/packardbell/ms2290/devicetree.cb b/src/mainboard/packardbell/ms2290/devicetree.cb index 17e1a4133f..0231b4b3db 100644 --- a/src/mainboard/packardbell/ms2290/devicetree.cb +++ b/src/mainboard/packardbell/ms2290/devicetree.cb @@ -20,6 +20,9 @@ ## chip northbridge/intel/nehalem + # IGD Displays + register "gfx.ndid" = "3" + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" register "gpu_dp_b_hotplug" = "0x04" register "gpu_dp_c_hotplug" = "0x04" diff --git a/src/mainboard/packardbell/ms2290/dsdt.asl b/src/mainboard/packardbell/ms2290/dsdt.asl index 0911494eb1..5fb43f3899 100644 --- a/src/mainboard/packardbell/ms2290/dsdt.asl +++ b/src/mainboard/packardbell/ms2290/dsdt.asl @@ -18,8 +18,6 @@ * Foundation, Inc. */ -#define HAVE_LCD_SCREEN 1 - DefinitionBlock( "dsdt.aml", "DSDT", |