diff options
author | Mario Scheithauer <mario.scheithauer@siemens.com> | 2018-04-23 10:55:39 +0200 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2018-04-26 06:54:45 +0000 |
commit | d127be102be3744b9b81036e5fa53acbddaae03b (patch) | |
tree | e0e30b4cda1154cc26570846c2a0f82a7aec0db4 /src/mainboard/siemens/mc_apl1/Kconfig | |
parent | 1732dcb90ce7e3863c7be28ec9275dd98d4faded (diff) | |
download | coreboot-d127be102be3744b9b81036e5fa53acbddaae03b.tar.xz |
siemens/mc_apl1: Provide baseboard and variant concepts
Siemens will provide further boards based on Apollo Lake. These differ
only slightly. To avoid copying the complete directory of the reference
board we simply create variants that only contain the differences, like
google/reef does.
To further the ability of multiple variant boards to share code provide
a place to land the split-up changes. This patch provides the tooling
by using a new Kconfig value, VARIANT_DIR, as well as the Make plumbing.
The directory layout with a single variant mc_apl1 (which is also the
baseboard) looks like this:
variants/baseboard - code
variants/baseboard/include/baseboard - headers
variants/mc_apl1 - code
variants/mc_apl1/include/variant - headers
New boards would then be added under their board name within the
'variants' directory.
No split has been done with providing different logic yet. This is
purely an organizational change.
Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/25785
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Diffstat (limited to 'src/mainboard/siemens/mc_apl1/Kconfig')
-rw-r--r-- | src/mainboard/siemens/mc_apl1/Kconfig | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index ae86894b68..44b81dc9fe 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -1,28 +1,32 @@ -if BOARD_SIEMENS_MC_APL1 -config BOARD_SPECIFIC_OPTIONS - def_bool y +config BOARD_SIEMENS_BASEBOARD_MC_APL1 + def_bool n select SOC_INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_TABLES - select DRIVER_INTEL_I210 select USE_SIEMENS_HWILIB select DRIVER_SIEMENS_NC_FPGA - select DRIVERS_I2C_RX6110SA - select DRIVERS_UART_8250IO select APL_SKIP_SET_POWER_LIMITS select NC_FPGA_NOTIFY_CB_READY +source "src/mainboard/siemens/mc_apl1/variants/*/Kconfig" + +if BOARD_SIEMENS_BASEBOARD_MC_APL1 + config MAINBOARD_DIR string default siemens/mc_apl1 +config VARIANT_DIR + string + default "mc_apl1" if BOARD_SIEMENS_MC_APL1 + config MAINBOARD_PART_NUMBER string - default "MC APL1" + default "MC APL1" if BOARD_SIEMENS_MC_APL1 config MAX_CPUS int - default 4 + default 8 -endif # BOARD_SIEMENS_MC_APL1 +endif # BOARD_SIEMENS_BASEBOARD_MC_APL1 |