diff options
author | Mario Scheithauer <mario.scheithauer@siemens.com> | 2018-04-23 10:55:39 +0200 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2018-04-26 06:54:45 +0000 |
commit | d127be102be3744b9b81036e5fa53acbddaae03b (patch) | |
tree | e0e30b4cda1154cc26570846c2a0f82a7aec0db4 /src/mainboard/siemens/mc_apl1/mainboard.c | |
parent | 1732dcb90ce7e3863c7be28ec9275dd98d4faded (diff) | |
download | coreboot-d127be102be3744b9b81036e5fa53acbddaae03b.tar.xz |
siemens/mc_apl1: Provide baseboard and variant concepts
Siemens will provide further boards based on Apollo Lake. These differ
only slightly. To avoid copying the complete directory of the reference
board we simply create variants that only contain the differences, like
google/reef does.
To further the ability of multiple variant boards to share code provide
a place to land the split-up changes. This patch provides the tooling
by using a new Kconfig value, VARIANT_DIR, as well as the Make plumbing.
The directory layout with a single variant mc_apl1 (which is also the
baseboard) looks like this:
variants/baseboard - code
variants/baseboard/include/baseboard - headers
variants/mc_apl1 - code
variants/mc_apl1/include/variant - headers
New boards would then be added under their board name within the
'variants' directory.
No split has been done with providing different logic yet. This is
purely an organizational change.
Change-Id: Ia3c1f45daee3b9690a448b82edbeec552ee05973
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/25785
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Diffstat (limited to 'src/mainboard/siemens/mc_apl1/mainboard.c')
-rw-r--r-- | src/mainboard/siemens/mc_apl1/mainboard.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index 18cb660ea1..ec110d87a5 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -2,7 +2,7 @@ * This file is part of the coreboot project. * * Copyright 2016 Google Inc. - * Copyright (C) 2017 Siemens AG + * Copyright (C) 2017-2018 Siemens AG * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -32,7 +32,7 @@ #include <bootstate.h> #include <timer.h> #include <timestamp.h> -#include "brd_gpio.h" +#include <baseboard/variants.h> #include "ptn3460.h" #define MAX_PATH_DEPTH 12 @@ -194,7 +194,7 @@ static void mainboard_init(void *chip_info) const struct pad_config *pads; size_t num; - pads = brd_gpio_table(&num); + pads = variant_gpio_table(&num); gpio_configure_pads(pads, num); config_pmic_imon(); |