src/mainboard/siemens: Use PTN3460 chip driver

This patch replaces and cleans up the redundant PTN3460 driver files in
/mainboard/siemens directories by using the now available driver in
src/drivers/i2c/ptn3460 and providing mainboard specific functions to
the driver.

TEST=Display is working on Siemens mainboards (e.g. mc_tcu3, mc_apl1, ...).

Change-Id: I976a502e7176a356bab772758250db3cdff529b9
Signed-off-by: Uwe Poeche <uwe.poeche@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36643
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

8 files changed, 123 insertions, 316 deletions

diff --git a/src/mainboard/siemens/mc_tcu3/Kconfig b/src/mainboard/siemens/mc_tcu3/Kconfig
index 508aaebefb..8e01cdec4f 100644
--- a/src/mainboard/siemens/mc_tcu3/Kconfig
+++ b/src/mainboard/siemens/mc_tcu3/Kconfig
@@ -29,6 +29,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select USE_BLOBS
 	select CBFS_AUTOGEN_ATTRIBUTES
 	select USE_SIEMENS_HWILIB
+	select DRIVERS_I2C_PTN3460
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/siemens/mc_tcu3/Makefile.inc b/src/mainboard/siemens/mc_tcu3/Makefile.inc
index 05b4e60193..3de042242b 100644
--- a/src/mainboard/siemens/mc_tcu3/Makefile.inc
+++ b/src/mainboard/siemens/mc_tcu3/Makefile.inc
@@ -17,4 +17,3 @@
 ramstage-y += gpio.c
 ramstage-y += irqroute.c
 ramstage-y += lcd_panel.c
-ramstage-y += ptn3460.c
diff --git a/src/mainboard/siemens/mc_tcu3/devicetree.cb b/src/mainboard/siemens/mc_tcu3/devicetree.cb
index 433eebeabf..a1416e490e 100644
--- a/src/mainboard/siemens/mc_tcu3/devicetree.cb
+++ b/src/mainboard/siemens/mc_tcu3/devicetree.cb
@@ -50,7 +50,12 @@ chip soc/intel/fsp_baytrail
 		device pci 16.0 off end # 8086 0F37 - OTG controller
 		device pci 17.0 on end	# 8086 0F50 - EMMC 4.5 Port (MMC1 pins) - Only 1 EMMC port at a time
 		device pci 18.0 on end	# 8086 0F40 - SIO - DMA
-		device pci 18.1 on end	# 8086 0F41 -   I2C Port 1
+		device pci 18.1 on 	# 8086 0F41 -   I2C Port 1
+			# Enable external display bridge (eDP to LVDS)
+			chip drivers/i2c/ptn3460
+				device i2c 0x20 on end	# PTN3460 DP2LVDS Bridge
+			end
+		end
 		device pci 18.2 on end	# 8086 0F42 -   I2C Port 2
 		device pci 18.3 on end	# 8086 0F43 -   I2C Port 3
 		device pci 18.4 on end	# 8086 0F44 -   I2C Port 4
diff --git a/src/mainboard/siemens/mc_tcu3/lcd_panel.c b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
index c4456afb7a..c4660ee8cc 100644
--- a/src/mainboard/siemens/mc_tcu3/lcd_panel.c
+++ b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
@@ -1,7 +1,7 @@
 /*
- * This file is part of the coreboot project.
+* This file is part of the coreboot project.
  *
- * Copyright (C) 2014 Siemens AG
+ * Copyright (C) 2014-2019 Siemens AG
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,17 +14,22 @@
  */
 
 #include <console/console.h>
+#include <device/device.h>
+#include <drivers/i2c/ptn3460/ptn3460.h>
+#include <hwilib.h>
 #include <string.h>
+#include <types.h>
+
 #include "soc/gpio.h"
 #include "lcd_panel.h"
-#include "ptn3460.h"
 
+# define MAX_HWI_NAME_LENGTH 20
 
 /** \brief Reads GPIOs used for LCD panel encoding and returns the 4 bit value
  * @param  no parameters
  * @return LCD panel type encoded in 4 bits
  */
-u8 get_lcd_panel_type(void)
+static u8 get_lcd_panel_type(void)
 {
 	u8 lcd_type_gpio;
 
@@ -35,48 +40,134 @@ u8 get_lcd_panel_type(void)
 	/* There is an inverter in this signals so we need to invert them as well */
 	return ((~lcd_type_gpio) & 0x0f);
 }
-
-/** \brief Set up LCD panel
- * @param  no parameters
- * @return 0 on success otherwise error value
+/** \brief This function checks which LCD panel type is used with the mainboard
+ *         and provides the name of the matching EDID data set in CBFS.
+ *  @param Pointer to the filename in CBFS where the EDID data is located
+ *  @return CB_SUCCESS on success otherwise CB_ERR
  */
-int setup_lcd_panel(void)
+static enum cb_err get_hwi_filename(char *hwi_block)
 {
 	u8 lcd_type;
-	int status;
-	char blockname[33];
+	enum cb_err ret = CB_SUCCESS;
 
 	lcd_type = get_lcd_panel_type();
 	printk(BIOS_INFO, "LCD: Found panel type %d\n", lcd_type);
 
 	switch (lcd_type) {
 	case LCD_PANEL_TYPE_10_INCH:
-		strcpy(blockname, "hwinfo10.hex");
+		strcpy(hwi_block, "hwinfo10.hex");
 		break;
 	case LCD_PANEL_TYPE_12_INCH:
-		strcpy(blockname, "hwinfo12.hex");
+		strcpy(hwi_block, "hwinfo12.hex");
 		break;
 	case LCD_PANEL_TYPE_15_INCH:
-		strcpy(blockname, "hwinfo15.hex");
+		strcpy(hwi_block, "hwinfo15.hex");
 		break;
 	case LCD_PANEL_TYPE_19_INCH:
-		strcpy(blockname, "hwinfo19.hex");
+		strcpy(hwi_block, "hwinfo19.hex");
 		break;
 	case LCD_PANEL_TYPE_EDID:
-		strcpy(blockname, "hwinfo.hex");
+		strcpy(hwi_block, "hwinfo.hex");
 		break;
 	default:
 		printk(BIOS_ERR, "LCD: No supported panel found.\n");
-		return 1;
+		ret = CB_ERR;
 		break;
 	}
+	return ret;
+}
+
+/** \brief This function provides EDID data to the driver for DP2LVDS Bridge (PTN3460)
+ * @param  edid_data	pointer to EDID data in driver
+*/
+enum cb_err mb_get_edid(uint8_t edid_data[0x80])
+{
+	char hwi_block[MAX_HWI_NAME_LENGTH];
+
+	if (get_hwi_filename(hwi_block) != CB_SUCCESS)
+		return CB_ERR;
+
+	if (hwilib_find_blocks(hwi_block) != CB_SUCCESS) {
+		printk(BIOS_ERR, "LCD: Info block \"%s\" not found!\n", hwi_block);
+		return CB_ERR;
+	}
+
+	/* Get EDID data from hwinfo block */
+	if (hwilib_get_field(Edid, edid_data, PTN_EDID_LEN) != PTN_EDID_LEN) {
+		printk(BIOS_ERR, "LCD: No EDID data available in %s\n", hwi_block);
+		return CB_ERR;
+	}
+	return CB_SUCCESS;
+}
+
+/** \brief This function provides EDID block [0..6] to the driver for DP2LVDS Bridge (PTN3460)
+ * which has to be used.
+*/
+uint8_t mb_select_edid_table(void)
+{
+	return 6; /* With this mainboard we use EDID block 6 for emulation in PTN3460. */
+}
+
+/** \brief Function to enable mainboard to adjust the config data of PTN3460.
+ * @param   *cfg_ptr  Pointer to the PTN config structure to modify.
+ * @return  -1 on error; PTN_CFG_MODIFIED if data was modified and needs to be updated.
+*/
+int mb_adjust_cfg(struct ptn_3460_config *cfg)
+{
+	char hwi_block[MAX_HWI_NAME_LENGTH];
+	uint8_t disp_con = 0, color_depth = 0;
+	uint8_t hwid[4], tcu31_hwid[4] = {7, 9, 2, 0};
+
+	if (get_hwi_filename(hwi_block) != CB_SUCCESS)
+		return -1;
+	if (hwilib_find_blocks(hwi_block) != CB_SUCCESS) {
+		printk(BIOS_ERR, "LCD: Info block \"%s\" not found!\n", hwi_block);
+		return -1;
+	}
 
-	/* Now that we have the panel type, set up the DP2LVDS converter */
-	status = ptn3460_init(blockname);
-	if (status)
-		printk(BIOS_ERR, "LCD: Setup PTN with status 0x%x\n", status);
-	else
-		printk(BIOS_INFO, "LCD: Setup PTN with status 0x%x\n", status);
+	if (hwilib_get_field(PF_DisplCon, &disp_con, sizeof(disp_con)) != sizeof(disp_con)) {
+		printk(BIOS_ERR, "LCD: Missing panel features from %s\n", hwi_block);
+		return -1;
+	}
+	if (hwilib_get_field(PF_Color_Depth, &color_depth,
+			     sizeof(color_depth)) != sizeof(color_depth)) {
+		printk(BIOS_ERR, "LCD: Missing panel features from %s\n", hwi_block);
+		return -1;
+	}
+	/* Set up configuration data according to the hwinfo block we got. */
+	cfg->dp_interface_ctrl = 0x00;
+	cfg->lvds_interface_ctrl1 = 0x00;
+	if (disp_con == PF_DISPLCON_LVDS_DUAL) {
+		/* Turn on dual LVDS lane and clock. */
+		cfg->lvds_interface_ctrl1 |= 0x0b;
+	}
+	if (color_depth == PF_COLOR_DEPTH_6BIT) {
+		/* Use 18 bits per pixel. */
+		cfg->lvds_interface_ctrl1 |= 0x20;
+	}
+	/* No clock spreading, 300 mV LVDS swing. */
+	cfg->lvds_interface_ctrl2 = 0x03;
+	/* Swap LVDS even and odd lanes for HW-ID 7.9.2.0 only. */
+	if (hwilib_get_field(HWID, hwid, sizeof(hwid)) == sizeof(hwid) &&
+	    !(memcmp(hwid, tcu31_hwid, sizeof(hwid)))) {
+		/* Swap LVDS even and odd lane. */
+		cfg->lvds_interface_ctrl3 = 0x01;
+	} else {
+		 /* no LVDS lane swap */
+		cfg->lvds_interface_ctrl3 = 0x00;
+	}
+	/* Delay T2 (VDD to LVDS active) by 16 ms. */
+	cfg->t2_delay = 1;
+	/* 500 ms from LVDS to backlight active. */
+	cfg->t3_timing = 10;
+	/* 1 second re-power delay. */
+	cfg->t12_timing = 20;
+	/* 150 ms backlight off to LVDS inactive. */
+	cfg->t4_timing = 3;
+	/* Delay T5 (LVDS to VDD inactive) by 16 ms. */
+	cfg->t5_delay = 1;
+	/* Enable backlight control. */
+	cfg->backlight_ctrl = 0;
 
-	return status;
+	return PTN_CFG_MODIFIED;
 }
diff --git a/src/mainboard/siemens/mc_tcu3/lcd_panel.h b/src/mainboard/siemens/mc_tcu3/lcd_panel.h
index a27cc52e4d..e119d7aaef 100644
--- a/src/mainboard/siemens/mc_tcu3/lcd_panel.h
+++ b/src/mainboard/siemens/mc_tcu3/lcd_panel.h
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2014 Siemens AG
+ * Copyright (C) 2014-2019 Siemens AG
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -28,8 +28,4 @@
 #define LCD_PANEL_TYPE_19_INCH	1
 #define LCD_PANEL_TYPE_EDID	15
 
-u8 get_lcd_panel_type(void);
-int setup_lcd_panel(void);
-
-
 #endif /* _LCD_PANEL_H_ */
diff --git a/src/mainboard/siemens/mc_tcu3/mainboard.c b/src/mainboard/siemens/mc_tcu3/mainboard.c
index 955193fec2..7950572e99 100644
--- a/src/mainboard/siemens/mc_tcu3/mainboard.c
+++ b/src/mainboard/siemens/mc_tcu3/mainboard.c
@@ -23,8 +23,6 @@
 #endif
 #include <hwilib.h>
 #include <i210.h>
-#include "lcd_panel.h"
-
 
 /** \brief This function will search for a MAC address which can be assigned
  *         to a MACPHY.
@@ -69,12 +67,10 @@ enum cb_err mainboard_get_mac_address(struct device *dev, uint8_t mac[6])
  */
 static void mainboard_enable(struct device *dev)
 {
-
 }
 
 static void mainboard_final(void *chip_info)
 {
-	setup_lcd_panel();
 }
 
 struct chip_operations mainboard_ops = {
diff --git a/src/mainboard/siemens/mc_tcu3/ptn3460.c b/src/mainboard/siemens/mc_tcu3/ptn3460.c
deleted file mode 100644
index 56f51f9647..0000000000
--- a/src/mainboard/siemens/mc_tcu3/ptn3460.c
+++ /dev/null
@@ -1,209 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2014-2019 Siemens AG
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <console/console.h>
-#include <hwilib.h>
-#include <string.h>
-#include <delay.h>
-#include <types.h>
-#include <device/i2c_simple.h>
-#include "soc/i2c.h"
-#include "ptn3460.h"
-
-/** \brief This functions sets up the DP2LVDS-converter to be used with the
- *         appropriate lcd panel
- * @param  *hwi_block	Filename in CBFS of the block to use as HW-Info
- * @return		0 on success or error code
- */
-int ptn3460_init(char *hwi_block)
-{
-	struct ptn_3460_config cfg;
-	int status;
-	uint8_t disp_con = 0, color_depth = 0;
-	uint8_t edid_data[0x80];
-	uint8_t hwid[4], tcu31_hwid[4] = {7, 9, 2, 0};
-	uint8_t i;
-
-	if (!hwi_block || hwilib_find_blocks(hwi_block) != CB_SUCCESS) {
-		printk(BIOS_ERR, "LCD: Info block \"%s\" not found!\n",
-			hwi_block);
-		return 1;
-	}
-
-	/* Get all needed information from hwinfo block */
-	if (hwilib_get_field(Edid, edid_data, 0x80) != sizeof(edid_data)) {
-		printk(BIOS_ERR, "LCD: No EDID data available in %s\n",
-			hwi_block);
-		return 1;
-	}
-	if ((hwilib_get_field(PF_DisplCon, &disp_con, 1) != 1)) {
-		printk(BIOS_ERR, "LCD: Missing panel features from %s\n",
-			hwi_block);
-		return 1;
-	}
-	if (hwilib_get_field(PF_Color_Depth, &color_depth, 1) != 1) {
-		printk(BIOS_ERR, "LCD: Missing panel features from %s\n",
-			hwi_block);
-		return 1;
-	}
-	/* Here, all the desired information for setting up DP2LVDS converter*/
-	/* are present. Inside the converter, table 6 will be used for */
-	/* the timings. */
-	if ((status = ptn3460_write_edid(6, edid_data)) != 0)
-		return status;
-	/* Select this table to be emulated */
-	ptn_select_edid(6);
-	/* Read PTN configuration data */
-	status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_CONFIG_OFF, (u8 *) &cfg,
-				sizeof(struct ptn_3460_config));
-	if (status)
-		return (PTN_BUS_ERROR | status);
-
-	/* Set up configuration data according to the hwinfo blocks we get */
-	cfg.dp_interface_ctrl = 0;
-	cfg.lvds_interface_ctrl1 = 0x00;
-	if (disp_con == PF_DISPLCON_LVDS_DUAL)
-		cfg.lvds_interface_ctrl1 |= 0x0b; /* Turn on dual LVDS lane and clock */
-	if (color_depth == PF_COLOR_DEPTH_6BIT)
-		cfg.lvds_interface_ctrl1 |= 0x20; /* Use 18 bits per pixel */
-	cfg.lvds_interface_ctrl2 = 0x03;  /* no clock spreading, 300 mV LVDS swing */
-	/* Swap LVDS even and odd lanes for HW-ID 7.9.2.0 only. */
-	if (hwilib_get_field(HWID, hwid, sizeof(hwid)) == sizeof(hwid) &&
-	    !(memcmp(hwid, tcu31_hwid, sizeof(hwid)))) {
-		cfg.lvds_interface_ctrl3 = 0x01;  /* swap LVDS even and odd */
-	} else
-		cfg.lvds_interface_ctrl3 = 0x00;  /* no LVDS signal swap */
-	cfg.t2_delay = 1;		/* Delay T2 (VDD to LVDS active) by 16 ms */
-	cfg.t3_timing = 10;		/* 500 ms from LVDS to backlight active */
-	cfg.t12_timing = 20;		/* 1 second re-power delay */
-	cfg.t4_timing = 3;		/* 150 ms backlight off to LVDS inactive */
-	cfg.t5_delay = 1;		/* Delay T5 (LVDS to VDD inactive) by 16 ms */
-	cfg.backlight_ctrl = 0;		/* Enable backlight control */
-
-	/* Write back configuration data to PTN3460 */
-	for (i = 0; i < sizeof(struct ptn_3460_config); i++) {
-		status = i2c_writeb(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_CONFIG_OFF + i,
-				    *(((uint8_t *) &cfg) + i));
-		if (status)
-			return (PTN_BUS_ERROR | status);
-	}
-
-	return PTN_NO_ERROR;
-}
-
-/** \brief This functions reads one desired EDID data structure from PTN3460
- * @param  edid_num Number of EDID that must be read (0..6)
- * @param  *data    Pointer to a buffer where to store read data
- * @return          0 on success or error code
- */
-int ptn3460_read_edid(u8 edid_num, u8 *data)
-{
-	int status;
-
-	if (edid_num > PTN_MAX_EDID_NUM)
-		return PTN_INVALID_EDID;
-	/* First enable access to the desired EDID table */
-	status = i2c_writeb(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_CONFIG_OFF + 5, edid_num);
-	if (status)
-		return (PTN_BUS_ERROR | status);
-
-	/* Now we can simply read back EDID-data */
-	status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_EDID_OFF, data,
-				PTN_EDID_LEN);
-	if (status)
-		return (PTN_BUS_ERROR | status);
-	else
-		return PTN_NO_ERROR;
-}
-
-/** \brief This functions writes one EDID data structure to PTN3460
- * @param  edid_num  Number of EDID that must be written (0..6)
- * @param  *data     Pointer to a buffer where data to write is stored in
- * @return           0 on success or error code
- */
-int ptn3460_write_edid(u8 edid_num, u8 *data)
-{
-	int status;
-	int i;
-
-	if (edid_num > PTN_MAX_EDID_NUM)
-		return PTN_INVALID_EDID;
-
-	/* First enable access to the desired EDID table */
-	status = i2c_writeb(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_CONFIG_OFF + 5, edid_num);
-	if (status)
-		return (PTN_BUS_ERROR | status);
-
-	/* Now we can simply write EDID-data to ptn3460 */
-	for (i = 0; i < PTN_EDID_LEN; i++) {
-		status = i2c_writeb(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_EDID_OFF + i,
-				    data[i]);
-		if (status)
-			return (PTN_BUS_ERROR | status);
-	}
-	return PTN_NO_ERROR;
-}
-
-/** \brief  This functions selects one of 7 EDID-tables inside PTN3460
- *          which should be emulated on display port and turn emulation ON
- * @param   edid_num  Number of EDID to emulate (0..6)
- * @return            0 on success or error code
- */
-int ptn_select_edid (u8 edid_num)
-{
-	int status;
-	u8 val;
-
-	if (edid_num > PTN_MAX_EDID_NUM)
-		return PTN_INVALID_EDID;
-	/* Enable emulation of the desired EDID table */
-	val = (edid_num << 1) | 1;
-	status = i2c_writeb(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_CONFIG_OFF + 4, val);
-	if (status)
-		return (PTN_BUS_ERROR | status);
-	else
-		return PTN_NO_ERROR;
-}
-
-/** \brief This functions performs a flash operation which will write
- *         current configuration table (all the EDID-tables and the
- *         configuration space with a total amount of 1 KByte)
- *         to the internal flash of PTN3460
- * @param  none
- * @return 0 on success or error code
- */
-int ptn3460_flash_config(void)
-{
-	int status, i;
-	struct ptn_3460_flash flash;
-
-	flash.cmd = 0x01;	/* perform erase and flash cycle */
-	flash.magic = 0x7845;	/* Magic number to protect flash operation */
-	flash.trigger = 0x56;	/* This value starts flash operation */
-
-	for (i = 0; i < sizeof(struct ptn_3460_flash); i++) {
-		status = i2c_writeb(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, PTN_FLASH_CFG_OFF+i,
-				*(((uint8_t *) &flash) + i));
-			if (status)
-				return (PTN_BUS_ERROR | status);
-	}
-	if (status) {
-		return (PTN_BUS_ERROR | status);
-	} else {
-		/* To ensure the flash operation is finished, we have to wait 300 ms */
-		mdelay(300);
-		return PTN_NO_ERROR;
-	}
-}
diff --git a/src/mainboard/siemens/mc_tcu3/ptn3460.h b/src/mainboard/siemens/mc_tcu3/ptn3460.h
deleted file mode 100644
index 8dc002dc39..0000000000
--- a/src/mainboard/siemens/mc_tcu3/ptn3460.h
+++ /dev/null
@@ -1,72 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2014 Siemens AG
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#ifndef PTN3460_H_
-#define PTN3460_H_
-
-#include "lcd_panel.h"
-
-#define PTN_SLAVE_ADR		0x20
-#define PTN_I2C_CONTROLLER	0
-
-#define PTN_EDID_OFF		0x00
-#define PTN_EDID_LEN		0x80
-#define PTN_CONFIG_OFF		0x80
-#define PTN_CONFIG_LEN		0x19
-#define PTN_FLASH_CFG_OFF	0xE8
-#define PTN_FLASH_CFG_LEN	0x04
-#define PTN_MAX_EDID_NUM	6
-
-/* Define some error codes that can be used */
-#define PTN_NO_ERROR		0x00000000
-#define PTN_BUS_ERROR		0x10000000
-#define PTN_INVALID_EDID	0x20000000
-
-struct ptn_3460_config{
-	u8	dp_interface_ctrl;	/* DisplayPort interface control */
-	u8	lvds_interface_ctrl1;	/* LVDS interface control register 1 */
-	u8	lvds_interface_ctrl2;	/* LVDS interface control register 2 */
-	u8	lvds_interface_ctrl3;	/* LVDS interface control register 3 */
-	u8	edid_rom_emulation;	/* select which EDID-block is emulated */
-	u8	edid_rom_access_ctrl;	/* select which EDID block to map to 0..0x7F */
-	u8	pwm_min[3];		/* smallest PWM frequency for back light */
-	u8	pwm_max[3];		/* biggest PWM frequency for back light */
-	u8	fast_link_ctrl;		/* Fast link training control register */
-	u8	pin_cfg_ctrl1;		/* Pin configuration control register 1 */
-	u8	pin_cfg_ctrl2;		/* Pin configuration control register 2 */
-	u8	pwm_default;		/* Default PWM bit count in DPCD register */
-	u16	pwm_value;		/* Current PWM bit count in DPCD register */
-	u8	pwm_default_freq;	/* Default PWM frequency in DPCD register */
-	u8	t3_timing;		/* Panel T3 timing value */
-	u8	t12_timing;		/* Panel T12 timing value */
-	u8	backlight_ctrl;		/* Back light control register */
-	u8	t2_delay;		/* Panel T2 delay */
-	u8	t4_timing;		/* Panel T4 timing value */
-	u8	t5_delay;		/* Panel T5 delay */
-} __packed;
-
-struct ptn_3460_flash{
-	u8	cmd;			/* Flash command (erase or erase and flash) */
-	u16	magic;			/* Magic number needed by the flash algorithm */
-	u8	trigger;		/* Trigger for starting flash operation */
-} __packed;
-
-
-int ptn3460_init(char *hwi_block);
-int ptn3460_read_edid(u8 edid_num, u8 *data);
-int ptn3460_write_edid(u8 edid_num, u8 *data);
-int ptn_select_edid(u8 edid_num);
-int ptn3460_flash_config(void);
-#endif /* PTN3460_H_ */