diff options
| author | Mario Scheithauer <mario.scheithauer@siemens.com> | 2017-06-21 12:42:10 +0200 |
|---|---|---|
| committer | Werner Zeh <werner.zeh@siemens.com> | 2017-06-23 06:52:25 +0000 |
| commit | 71dacacb748a73e44ea86ec571cc4ec9ff667d9d (patch) | |
| tree | 622e8d649dafc5c625a50b7ff9b87b005eb34270 /src/mainboard/siemens | |
| parent | db666a4d6114e30f2377a6cdaeaaf64b1128290a (diff) | |
| download | coreboot-71dacacb748a73e44ea86ec571cc4ec9ff667d9d.tar.xz | |
siemens/mc_apl1: Enable decoding for COM 3 on LPC
It does not work to enable the LPC range in the function
mainboard_init() because the LPC bus driver closes the range during PCI
enumeration again. For this reason, enabling decoding of the address
range for COM 3 will be done at a later point in time -
mainboard_final().
Change-Id: I452bca4e430b1ea75e4a327591da84500491fe84
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/20295
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Diffstat (limited to 'src/mainboard/siemens')
| -rw-r--r-- | src/mainboard/siemens/mc_apl1/mainboard.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index 2d8a080d54..f077c14549 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -110,9 +110,6 @@ static void mainboard_init(void *chip_info) pads = brd_gpio_table(&num); gpio_configure_pads(pads, num); - - /* Enable additional I/O decoding range on LPC for COM 3 */ - lpc_open_pmio_window(0x3e8, 8); } static void mainboard_final(void *chip_info) @@ -128,6 +125,9 @@ static void mainboard_final(void *chip_info) printk(BIOS_ERR, "LCD: Set up PTN with status 0x%x\n", status); else printk(BIOS_INFO, "LCD: Set up PTN was successful.\n"); + + /* Enable additional I/O decoding range on LPC for COM 3 */ + lpc_open_pmio_window(0x3e8, 8); } struct chip_operations mainboard_ops = { |