diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2012-07-10 14:26:43 +0300 |
|---|---|---|
| committer | Rudolf Marek <r.marek@assembler.cz> | 2012-07-23 17:44:13 +0200 |
| commit | 505414a6cfb2aeef455b5144e4b96fc27f19eb39 (patch) | |
| tree | 25ecfec62c9340f62a502b50f89f5dc58000657b /src/mainboard/technexion | |
| parent | ce6e9fed2e1e0e5a493d1133caf5c6b9f713b7fc (diff) | |
| download | coreboot-505414a6cfb2aeef455b5144e4b96fc27f19eb39.tar.xz | |
AMD and GFXUMA: drop redundant use of lb_add_memory_range()
Use of uma_resource() in AMD northbridge code created a memory
resource marked as reserved. Such resources are removed
from system memory in write_coreboot_table().
Change-Id: Ib5e49e851d6622d8ece9d6d612e245b3962b9167
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1233
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
Diffstat (limited to 'src/mainboard/technexion')
| -rw-r--r-- | src/mainboard/technexion/tim5690/mainboard.c | 9 | ||||
| -rw-r--r-- | src/mainboard/technexion/tim8690/mainboard.c | 9 |
2 files changed, 0 insertions, 18 deletions
diff --git a/src/mainboard/technexion/tim5690/mainboard.c b/src/mainboard/technexion/tim5690/mainboard.c index d1994cb29e..5a22182df8 100644 --- a/src/mainboard/technexion/tim5690/mainboard.c +++ b/src/mainboard/technexion/tim5690/mainboard.c @@ -247,15 +247,6 @@ static void tim5690_enable(device_t dev) int add_mainboard_resources(struct lb_memory *mem) { - /* UMA is removed from system memory in the northbridge code, but - * in some circumstances we want the memory mentioned as reserved. - */ -#if CONFIG_GFXUMA - printk(BIOS_INFO, "uma_memory_base=0x%llx, uma_memory_size=0x%llx \n", - uma_memory_base, uma_memory_size); - lb_add_memory_range(mem, LB_MEM_RESERVED, - uma_memory_base, uma_memory_size); -#endif technexion_post_code(LED_MESSAGE_FINISH); return 0; } diff --git a/src/mainboard/technexion/tim8690/mainboard.c b/src/mainboard/technexion/tim8690/mainboard.c index 80a43ffebf..f7ec110fee 100644 --- a/src/mainboard/technexion/tim8690/mainboard.c +++ b/src/mainboard/technexion/tim8690/mainboard.c @@ -154,15 +154,6 @@ static void tim8690_enable(device_t dev) int add_mainboard_resources(struct lb_memory *mem) { - /* UMA is removed from system memory in the northbridge code, but - * in some circumstances we want the memory mentioned as reserved. - */ -#if CONFIG_GFXUMA - printk(BIOS_INFO, "uma_memory_base=0x%llx, uma_memory_size=0x%llx \n", - uma_memory_base, uma_memory_size); - lb_add_memory_range(mem, LB_MEM_RESERVED, - uma_memory_base, uma_memory_size); -#endif return 0; } |