diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-05-26 17:38:23 +1000 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-08-14 15:12:26 +0200 |
| commit | 1ab202795532cdce155e42738d84e77a3e77ceb2 (patch) | |
| tree | b5aebd432a005f7af62e05b81536922acec3e366 /src/mainboard/tyan | |
| parent | 67584f210a95188a5ff0d517130ac3cad4f38964 (diff) | |
| download | coreboot-1ab202795532cdce155e42738d84e77a3e77ceb2.tar.xz | |
Intel: Add common header file for CAR setup
When passing '-ffreestanding' the 'main' romstage.c may no longer
necessarily be considered the entry point.
From the C specification in 5.1.2.1 Freestanding environment;
"In a freestanding environment (in which C program execution may take
place without any benefit of an operating system), the name and type of
the function called at program startup are implementation-defined."
Clang complains about these being missing as Clang is somewhat more
strict about the spec than GNU/GCC is. An advantage here is that a
different entry-point type-signature shall now be warned about at
compile time.
Change-Id: I467001adabd47958c30c9a15e3248e42ed1151f3
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5872
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src/mainboard/tyan')
| -rw-r--r-- | src/mainboard/tyan/s1846/romstage.c | 1 | ||||
| -rw-r--r-- | src/mainboard/tyan/s2735/romstage.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/mainboard/tyan/s1846/romstage.c b/src/mainboard/tyan/s1846/romstage.c index bbd63eeb5e..78313fcc03 100644 --- a/src/mainboard/tyan/s1846/romstage.c +++ b/src/mainboard/tyan/s1846/romstage.c @@ -40,6 +40,7 @@ int spd_read_byte(unsigned int device, unsigned int address) return smbus_read_byte(device, address); } +#include <cpu/intel/car.h> void main(unsigned long bist) { pc87309_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); diff --git a/src/mainboard/tyan/s2735/romstage.c b/src/mainboard/tyan/s2735/romstage.c index 600d8069c7..1b03982fd0 100644 --- a/src/mainboard/tyan/s2735/romstage.c +++ b/src/mainboard/tyan/s2735/romstage.c @@ -34,6 +34,7 @@ static inline int spd_read_byte(unsigned device, unsigned address) #include "northbridge/intel/e7501/reset_test.c" #include "lib/generic_sdram.c" +#include <cpu/intel/car.h> void main(unsigned long bist) { static const struct mem_controller memctrl[] = { |