summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorMike Loptien <mike.loptien@se-eng.com>2013-03-15 13:31:20 -0600
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-03-17 19:55:43 +0100
commit8c72670ba5c4283b2a1a2513f47f40b949094648 (patch)
treed0d957921c3b70f68144a9191179ec3774a5c8e6 /src/mainboard
parent60d84ca22b57ae5705c0659aa07a59a3407c094e (diff)
downloadcoreboot-8c72670ba5c4283b2a1a2513f47f40b949094648.tar.xz
AMD Fam14 DSDT: Remove INI method from AZHD device
I am removing the _INI method from the AZHD device because it does not seem to do anything and causes errors in the FWTS[1] (Firmware Test Suite) test 'method'. The INI method performs device specific initialization and is run when OSPM loads a description table. It must only access OperationRegions that have been indicated as available by the _REG (Region) method. We do not have a _REG method and during my testing, I added a REG method but it did not seem to make a difference in the PCI register space. The bit fields defined as NSDI (Disable No Snoop), NSDO (Disable No Snoop Override), and NSEN (Enable No Snoop Request) do not ever get written from their default values. And writing to these bit fields does not seem to be necessary because I did not notice any change in audio functionality. In an effort to clean up as many FWTS errors as possible, I propose removing this method altogether. I have seen no change in operation (audio works with and without this method) and there does not seem to be any change in lspci or dmesg. FWTS information can be found here: [1]: https://wiki.ubuntu.com/Kernel/Reference/fwts This is the same chagne as made to Persimmon in Change-ID If8d86f: http://review.coreboot.org/#/c/2726/ Change-Id: Id560ea85a38f73aaba2c35447bbce46bd9c0d0dd Signed-off-by: Mike Loptien <mike.loptien@se-eng.com> Reviewed-on: http://review.coreboot.org/2741 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/amd/inagua/dsdt.asl8
-rw-r--r--src/mainboard/amd/south_station/dsdt.asl8
-rw-r--r--src/mainboard/amd/union_station/dsdt.asl8
3 files changed, 0 insertions, 24 deletions
diff --git a/src/mainboard/amd/inagua/dsdt.asl b/src/mainboard/amd/inagua/dsdt.asl
index dff59170de..acc85c6613 100644
--- a/src/mainboard/amd/inagua/dsdt.asl
+++ b/src/mainboard/amd/inagua/dsdt.asl
@@ -1385,14 +1385,6 @@ DefinitionBlock (
offset (0x6C),
MMDT, 16,
}
-
- Method(_INI) {
- If(LEqual(OSTP,3)){ /* If we are running Linux */
- Store(zero, NSEN)
- Store(one, NSDO)
- Store(one, NSDI)
- }
- }
} /* end AZHD */
Device(LIBR) {
diff --git a/src/mainboard/amd/south_station/dsdt.asl b/src/mainboard/amd/south_station/dsdt.asl
index dff59170de..acc85c6613 100644
--- a/src/mainboard/amd/south_station/dsdt.asl
+++ b/src/mainboard/amd/south_station/dsdt.asl
@@ -1385,14 +1385,6 @@ DefinitionBlock (
offset (0x6C),
MMDT, 16,
}
-
- Method(_INI) {
- If(LEqual(OSTP,3)){ /* If we are running Linux */
- Store(zero, NSEN)
- Store(one, NSDO)
- Store(one, NSDI)
- }
- }
} /* end AZHD */
Device(LIBR) {
diff --git a/src/mainboard/amd/union_station/dsdt.asl b/src/mainboard/amd/union_station/dsdt.asl
index b59ea7b39b..3f8031432a 100644
--- a/src/mainboard/amd/union_station/dsdt.asl
+++ b/src/mainboard/amd/union_station/dsdt.asl
@@ -1386,14 +1386,6 @@ DefinitionBlock (
offset (0x6C),
MMDT, 16,
}
-
- Method(_INI) {
- If(LEqual(OSTP,3)){ /* If we are running Linux */
- Store(zero, NSEN)
- Store(one, NSDO)
- Store(one, NSDI)
- }
- }
} /* end AZHD */
Device(LIBR) {