diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2014-03-03 15:08:10 -0800 |
|---|---|---|
| committer | Isaac Christensen <isaac.christensen@se-eng.com> | 2014-09-29 17:32:05 +0200 |
| commit | be1d1e7f838e09e67b8cc0e84cd842f4cf71f9ae (patch) | |
| tree | 2dcd318b245eaed4cb38f28a0f9f64b7bd0fe505 /src/mainboard | |
| parent | 3f1500f54f7d5d0bdc4b2f3a99cb7768d31066cc (diff) | |
| download | coreboot-be1d1e7f838e09e67b8cc0e84cd842f4cf71f9ae.tar.xz | |
google/panther: Be safe about invalid thermal readings
In case we get an invalid thermal reading, let's run the fan
at full speed rather than at low speed. This might impact the
user experiance slightly in cases where the bad reading does
not happen while the system is hot, but it will increase stability
in the cases where the system is actually overheating.
Also, set the critical temperature below tjmax, because otherwise
thermal shutdown by the OS will never be triggered.
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Change-Id: Iab262f1f17a5dff875c596d9e8d50e4e50ee90f9
Reviewed-on: https://chromium-review.googlesource.com/188556
Reviewed-by: Shawn Nematbakhsh <shawnn@chromium.org>
Commit-Queue: Stefan Reinauer <reinauer@chromium.org>
Tested-by: Stefan Reinauer <reinauer@chromium.org>
(cherry picked from commit 721fc2361ea9c6fea75409be57726294ce840f03)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6962
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/google/panther/acpi/thermal.asl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/panther/acpi/thermal.asl b/src/mainboard/google/panther/acpi/thermal.asl index 72b4ad8ec6..3a1f7be5f1 100644 --- a/src/mainboard/google/panther/acpi/thermal.asl +++ b/src/mainboard/google/panther/acpi/thermal.asl @@ -76,12 +76,12 @@ Scope (\_TZ) // Check for "no reading available" If (LEqual (Local0, 0x80)) { - Return (CTOK (\F2ON)) + Return (CTOK (\F0ON)) } // Check for invalid readings If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { - Return (CTOK (\F2ON)) + Return (CTOK (\F0ON)) } // PECI raw value is an offset from Tj_max |