summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorPatrick Rudolph <siro@das-labor.org>2018-07-28 12:47:42 +0200
committerPatrick Georgi <pgeorgi@google.com>2018-07-30 18:58:13 +0000
commitecb2399ab878ef0127630e1fd16942a842d92163 (patch)
tree426a1e8f34c2903b3aa70c1ca14fbfb99c41f5c7 /src/mainboard
parent5d3707bbc3b84f0df4530d57cd3d36b68574e22f (diff)
downloadcoreboot-ecb2399ab878ef0127630e1fd16942a842d92163.tar.xz
mb/google/parrot/smihandler: Use new PMBASE API
Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e Signed-off-by: Patrick Rudolph <siro@das-labor.org> Reviewed-on: https://review.coreboot.org/27679 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/parrot/smihandler.c12
1 files changed, 3 insertions, 9 deletions
diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c
index 7681065197..e30f78f3a1 100644
--- a/src/mainboard/google/parrot/smihandler.c
+++ b/src/mainboard/google/parrot/smihandler.c
@@ -20,6 +20,7 @@
#include <southbridge/intel/bd82x6x/pch.h>
#include <southbridge/intel/bd82x6x/me.h>
#include <southbridge/intel/common/pmutil.h>
+#include <southbridge/intel/common/pmbase.h>
#include <northbridge/intel/sandybridge/sandybridge.h>
#include <cpu/intel/model_206ax/model_206ax.h>
#include <elog.h>
@@ -29,7 +30,6 @@
static u8 mainboard_smi_ec(void)
{
u8 src;
- u32 pm1_cnt;
#if IS_ENABLED(CONFIG_ELOG_GSMI)
static int battery_critical_logged;
#endif
@@ -54,9 +54,7 @@ static u8 mainboard_smi_ec(void)
elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED);
#endif
/* Go to S5 */
- pm1_cnt = inl(smm_get_pmbase() + PM1_CNT);
- pm1_cnt |= (0xf << 10);
- outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);
+ write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));
break;
}
@@ -65,8 +63,6 @@ static u8 mainboard_smi_ec(void)
void mainboard_smi_gpi(u32 gpi_sts)
{
- u32 pm1_cnt;
-
printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts);
if (gpi_sts & (1 << EC_SMI_GPI)) {
/* Process all pending events from EC */
@@ -79,9 +75,7 @@ void mainboard_smi_gpi(u32 gpi_sts)
elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED);
#endif
/* Go to S5 */
- pm1_cnt = inl(smm_get_pmbase() + PM1_CNT);
- pm1_cnt |= (0xf << 10);
- outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);
+ write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));
}
}