superio/ite/common: Add temperature offset

Add a devicetree option to set temperature adjustment registers
required for thermal diode sensors and PECI. However, this commit does
not have the code needed to make PECI interface actually use these
registers. It only applies to diodes.

As a temporary workaround, one can set both THERMAL_DIODE and peci_tmpin
to the same TMPIN, e.g. TMPIN3.mode="THERMAL_DIODE" and peci_tmpin="3".
PECI, apparently, takes precedence over diode, so the adjustment register
will be set and PECI activated. Or simply use the followup patch, which
makes THERMAL_PECI a mode like THERMAL_DIODE.

I don't have hardware to test THERMAL_DIODE mode, but in case of PECI,
without this patch I had about -60°C on idle. Now, with offset 97,
which was taken from vendor bios, PECI readings became reasonable 35°C.

TEST=Set a temperature offset, then ensure that the value you set is
reflected in /sys/class/hwmon/hwmon*/temp[1-3]_offset

Change-Id: Ibce6809ca86b6c7c0c696676e309665fc57965d4
Signed-off-by: Vagiz Tarkhanov <rakkin@autistici.org>
Reviewed-on: https://review.coreboot.org/21843
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>

6 files changed, 20 insertions, 17 deletions

diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
index e1fbc51572..349a84533d 100644
--- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb
@@ -58,9 +58,9 @@ chip northbridge/amd/agesa/family15tn/root_complex
 				device pci 14.2 on  end # HDA	0x4383
 				device pci 14.3 on      # LPC	0x439d
 					chip superio/ite/it8728f
-						register "TMPIN1" = "THERMAL_RESISTOR"
-						register "TMPIN2" = "THERMAL_RESISTOR"
-						register "TMPIN3" = "THERMAL_RESISTOR"
+						register "TMPIN1.mode" = "THERMAL_RESISTOR"
+						register "TMPIN2.mode" = "THERMAL_RESISTOR"
+						register "TMPIN3.mode" = "THERMAL_RESISTOR"
 
 						register "FAN1.mode" = "FAN_SMART_AUTOMATIC"
 						register "FAN1.smart.tmpin" = "1"
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
index 128ff1847d..af0e4cc9db 100644
--- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
+++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb
@@ -58,9 +58,9 @@ chip northbridge/amd/agesa/family15tn/root_complex
 				device pci 14.2 on  end # HDA	0x4383
 				device pci 14.3 on      # LPC	0x439d
 					chip superio/ite/it8728f
-						register "TMPIN1" = "THERMAL_RESISTOR"
-						register "TMPIN2" = "THERMAL_RESISTOR"
-						register "TMPIN3" = "THERMAL_RESISTOR"
+						register "TMPIN1.mode" = "THERMAL_RESISTOR"
+						register "TMPIN2.mode" = "THERMAL_RESISTOR"
+						register "TMPIN3.mode" = "THERMAL_RESISTOR"
 
 						register "FAN1.mode" = "FAN_SMART_AUTOMATIC"
 						register "FAN1.smart.tmpin" = "1"
diff --git a/src/mainboard/foxconn/g41s-k/devicetree.cb b/src/mainboard/foxconn/g41s-k/devicetree.cb
index fae89e65fb..e57436ae7c 100644
--- a/src/mainboard/foxconn/g41s-k/devicetree.cb
+++ b/src/mainboard/foxconn/g41s-k/devicetree.cb
@@ -85,9 +85,10 @@ chip northbridge/intel/x4x		# Northbridge
 			device pci 1f.0 on		# ISA bridge
 				subsystemid 0x105b 0x0dda
 				chip superio/ite/it8720f	# Super I/O
-					register "TMPIN1" = "THERMAL_DIODE"
-					register "TMPIN2" = "THERMAL_RESISTOR"
-					register "TMPIN3" = "THERMAL_MODE_DISABLED"
+					register "TMPIN1.mode" = "THERMAL_DIODE"
+					register "TMPIN1.offset" = "0"
+					register "TMPIN2.mode" = "THERMAL_RESISTOR"
+					register "TMPIN3.mode" = "THERMAL_MODE_DISABLED"
 
 					register "ec.vin_mask" = "VIN_ALL"
 
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb b/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb
index acf743b18c..6bdc134b9a 100644
--- a/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb
+++ b/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb
@@ -110,9 +110,10 @@ chip northbridge/intel/i945
 			device pci 1f.0 on # LPC bridge
 				ioapic_irq 2 INTA 0x10
 				chip superio/ite/it8718f # Super I/O
-					register "TMPIN1" = "THERMAL_RESISTOR"
-					register "TMPIN2" = "THERMAL_RESISTOR"
-					register "TMPIN3" = "THERMAL_DIODE"
+					register "TMPIN1.mode" = "THERMAL_RESISTOR"
+					register "TMPIN2.mode" = "THERMAL_RESISTOR"
+					register "TMPIN3.mode" = "THERMAL_DIODE"
+					register "TMPIN3.offset" = "0"
 					register "ec.vin_mask" = "VIN_ALL"
 
 					register "FAN1.mode" = "FAN_SMART_AUTOMATIC"
diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb b/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
index 60004d25ea..39f790890e 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
@@ -82,9 +82,10 @@ chip northbridge/intel/x4x		# Northbridge
       device pci 1f.0 on		# ISA bridge
         subsystemid 0x1458 0x5001
         chip superio/ite/it8718f	# Super I/O
-          register "TMPIN1" = "THERMAL_RESISTOR"
-          register "TMPIN2" = "THERMAL_RESISTOR"
-          register "TMPIN3" = "THERMAL_DIODE"
+          register "TMPIN1.mode" = "THERMAL_RESISTOR"
+          register "TMPIN2.mode" = "THERMAL_RESISTOR"
+          register "TMPIN3.mode" = "THERMAL_DIODE"
+	  register "TMPIN3.offset" = "0"
           register "ec.vin_mask" = "VIN7 | VIN4 | VIN3 | VIN2 | VIN1 | VIN0"
 
           register "FAN1.mode" = "FAN_SMART_AUTOMATIC"
diff --git a/src/mainboard/roda/rv11/variants/rw11/devicetree.cb b/src/mainboard/roda/rv11/variants/rw11/devicetree.cb
index 845bca8183..d5f744e98f 100644
--- a/src/mainboard/roda/rv11/variants/rw11/devicetree.cb
+++ b/src/mainboard/roda/rv11/variants/rw11/devicetree.cb
@@ -113,8 +113,8 @@ chip northbridge/intel/sandybridge
 					end
 				end
 				chip superio/ite/it8783ef
-					register "TMPIN1"		= "THERMAL_RESISTOR"
-					register "TMPIN2"		= "THERMAL_RESISTOR"
+					register "TMPIN1.mode"		= "THERMAL_RESISTOR"
+					register "TMPIN2.mode"		= "THERMAL_RESISTOR"
 					register "ec.vin_mask"          = "VIN_ALL"
 					register "FAN1.mode"		= "FAN_SMART_AUTOMATIC"
 					register "FAN1.smart.tmpin"	= " 1"