summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorFrank Wu <frank_wu@compal.corp-partner.google.com>2019-06-26 17:13:05 +0800
committerFurquan Shaikh <furquan@google.com>2019-07-08 02:13:43 +0000
commit3076deb391a69ea502cbf1312a83cb56d91a9b01 (patch)
treeab40028d070ae69fd70b6b4dcb5cd251f0e8927b /src/mainboard
parentc2f6c1d544938459f4cc00d22126a6985c6fef85 (diff)
downloadcoreboot-3076deb391a69ea502cbf1312a83cb56d91a9b01.tar.xz
mb/google/hatch: Set GPP_D9 as enable pin for Goodix Touch Screen and
increase reset off delay time Goodix touchscreen cannot work in normal mode because PP3300_TOUCHSCREEN_DX dropped. Configure GPP_D9 as enable pin in the devicetree.cb to fix the power sequence. Increase reset_off_delay time from 1ms to 3ms to met the HW requirement. BUG=b:135287161 BRANCH=None TEST=local build and measure sequence with Goodix touch screen Change-Id: I33140869990aa4715c780b0fa322921e450530ef Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33808 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/hatch/variants/baseboard/gpio.c4
-rw-r--r--src/mainboard/google/hatch/variants/hatch/overridetree.cb4
-rw-r--r--src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb4
3 files changed, 8 insertions, 4 deletions
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index 528ab02c5d..1da3d756e2 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -181,8 +181,8 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_D7, NONE),
/* D8 : WWAN_CONFIG_3 */
PAD_NC(GPP_D8, NONE),
- /* D9 : GPP_D9 ==> NC */
- PAD_NC(GPP_D9, NONE),
+ /* D9 : GPP_D9 ==> EN_PP3300_DX_TOUCHSCREEN */
+ PAD_CFG_GPO(GPP_D9, 0, DEEP),
/* D10 : GPP_D10 ==> NC */
PAD_NC(GPP_D10, NONE),
/* D11 : GPP_D11 ==> NC */
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
index 2582940a1a..18878cee4a 100644
--- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
@@ -90,7 +90,9 @@ chip soc/intel/cannonlake
register "generic.reset_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)"
register "generic.reset_delay_ms" = "10"
- register "generic.reset_off_delay_ms" = "1"
+ register "generic.reset_off_delay_ms" = "3"
+ register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
+ register "generic.enable_delay_ms" = "12"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x01"
device i2c 5d on end
diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
index 373438cf8a..03218675c0 100644
--- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
@@ -81,7 +81,9 @@ chip soc/intel/cannonlake
register "generic.reset_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)"
register "generic.reset_delay_ms" = "10"
- register "generic.reset_off_delay_ms" = "1"
+ register "generic.reset_off_delay_ms" = "3"
+ register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"
+ register "generic.enable_delay_ms" = "12"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x01"
device i2c 5d on end